[alsa-devel] [PATCH 07/10] ASoC: soc-pcm: add snd_soc_dpcm_can_be() and remove duplicate code

Ranjani Sridharan ranjani.sridharan at linux.intel.com
Thu Feb 13 18:15:15 CET 2020


On Thu, 2020-02-13 at 13:26 +0900, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> Below functions are doing very similar things, the difference is
> only used state.
> 
> 	snd_soc_dpcm_can_be_free_stop()
> 	snd_soc_dpcm_can_be_params()
> 
> This patch adds common snd_soc_dpcm_can_be(), and use it from
> snd_soc_dpcm_can_be_free_stop() / snd_soc_dpcm_can_be_params().
> This can reduce duplicate code.

Morimoto-san,

Only minor but does it make it a bit more intuitive to call this new
function snd_soc_dpcm_check_state() or something equivalent maybe?

Thanks,
Ranjani



More information about the Alsa-devel mailing list