[alsa-devel] [PATCH] ASoC: core: delete component->card_list in soc_remove_component only

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Wed Sep 18 07:46:02 CEST 2019


Hi Liao

Thank you for your feedback

> > > To me, the easiest way to see the issue is force return - EPROBE_DEFER
> > > on codec driver's probe function and call
> > > list_del(&component->card_list); before calling
> > > soc_cleanup_component(component); So list_del() will be called twice and you
> > will see the issue.
> > 
> > OK, I could reproduce your issue.
> > And I think it will be solved if you can use
> > list_del_init() instead of list_del() at soc_cleanup_component() ?
> > (= without your patch)
> > 
> > 	- list_del()
> > 	+ list_del_init()
> > 
> > If possible, I want to cleanup all component related resource at
> > soc_cleanup_component(). Because it is easy to read / understand.
> 
> Thanks Morimoto san, I verified the solution works and agree with
> you. Will you send a patch to upstream?

Good to know !!
I'm happy if you can update it :)

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list