[alsa-devel] [PATCH] ASoC: core: delete component->card_list in soc_remove_component only

[Liao, Bard]

> -----Original Message-----
> From: Kuninori Morimoto [mailto:kuninori.morimoto.gx at renesas.com]
> Sent: Wednesday, September 18, 2019 1:46 PM
> To: Liao, Bard <bard.liao at intel.com>
> Cc: Bard liao <yung-chuan.liao at linux.intel.com>; broonie at kernel.org;
> tiwai at suse.de; alsa-devel at alsa-project.org; pierre-
> louis.bossart at linux.intel.com
> Subject: Re: [PATCH] ASoC: core: delete component->card_list in
> soc_remove_component only
> 
> 
> Hi Liao
> 
> Thank you for your feedback
> 
> > > > To me, the easiest way to see the issue is force return -
> > > > EPROBE_DEFER on codec driver's probe function and call
> > > > list_del(&component->card_list); before calling
> > > > soc_cleanup_component(component); So list_del() will be called
> > > > twice and you
> > > will see the issue.
> > >
> > > OK, I could reproduce your issue.
> > > And I think it will be solved if you can use
> > > list_del_init() instead of list_del() at soc_cleanup_component() ?
> > > (= without your patch)
> > >
> > > 	- list_del()
> > > 	+ list_del_init()
> > >
> > > If possible, I want to cleanup all component related resource at
> > > soc_cleanup_component(). Because it is easy to read / understand.
> >
> > Thanks Morimoto san, I verified the solution works and agree with you.
> > Will you send a patch to upstream?
> 
> Good to know !!
> I'm happy if you can update it :)

The original patch has been applied by Mark. Should I send a patch on top
of the original patch or overwrite the original one?


> 
> Thank you for your help !!
> Best regards
> ---
> Kuninori Morimoto