[alsa-devel] [PATCH] ASoC: rt1308: Add RT1308 amplifier driver

[Derek [方德義]]

> Subject: Re: [PATCH] ASoC: rt1308: Add RT1308 amplifier driver
> 
> On Mon, May 13, 2019 at 01:54:08PM +0000, Derek wrote:
> 
> > > I'm confused about what this limit is - is it just some arbatrary limit
> > > imposed in case some board has problems or is it an actual limit that
> > > comes from the chip?  If it's a "just in case" limit then the board
> > > should be the one doing the limiting, yes people can break things but
> > > it's difficult to get decision like that done sensibly in the CODEC
> > > driver in a way that works for everything and the general expectation is
> > > that this is all for use by system integrators rather than end users.
> 
> > It is an actual limit that comes from the chip.
> 
> If there is an actual limit in the chip the driver just shouldn't expose
> anything beyond what that limit is - the original thing I was calling
> out was that you're just hard coding a value for this setting into the
> driver, that just means that the expectation is that the values should
> be user settable within whatever the chip can support.  If there's
> settings that can't be supported at all the driver doesn't need to
> pretend to offer them.

I could remove comment for the limit setting in register patch/init list
to avoid users or integrators have any expectation.
And also there will not be any support at all the driver according to the
limit setting.
 
> ------Please consider the environment before printing this e-mail.