[alsa-devel] [PATCH] ASoC: rt1308: Add RT1308 amplifier driver

[Mark Brown]

On Mon, May 13, 2019 at 01:54:08PM +0000, Derek [方德義] wrote:

> > I'm confused about what this limit is - is it just some arbatrary limit
> > imposed in case some board has problems or is it an actual limit that
> > comes from the chip?  If it's a "just in case" limit then the board
> > should be the one doing the limiting, yes people can break things but
> > it's difficult to get decision like that done sensibly in the CODEC
> > driver in a way that works for everything and the general expectation is
> > that this is all for use by system integrators rather than end users.

> It is an actual limit that comes from the chip.

If there is an actual limit in the chip the driver just shouldn't expose
anything beyond what that limit is - the original thing I was calling
out was that you're just hard coding a value for this setting into the
driver, that just means that the expectation is that the values should
be user settable within whatever the chip can support.  If there's
settings that can't be supported at all the driver doesn't need to
pretend to offer them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 484 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20190513/86ce60a0/attachment.sig>