[alsa-devel] [PATCH v2] ASoC: Intel: Skylake: enable S24_LE format support

[Pierre-Louis Bossart]

On 3/23/19 9:10 AM, Jenny TC wrote:
> From: Jenny TC <jenny.tc at intel.com>
> 
> To enable S24_LE format, sample_type in topology fw has to be set to 1.
> But sample_type defined in topology firmware configuration is not
> getting reflected in the dsp param. This patch sets sample_type in base
> config so that the sample type defined in the topology firmware is reflected
> in the dsp params. This issues was uncovered while debugging the S24_LE format
> which require the MSB byte in 32 bit word to be skipped. Setting sample_type
> in topology firmware to 1 helps to skip MSB byte word.
> 
> Signed-off-by: Jenny TC <jenny.tc at intel.com>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

> ---
>   sound/soc/intel/skylake/skl-messages.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
> index 28c4806..4bf70b4 100644
> --- a/sound/soc/intel/skylake/skl-messages.c
> +++ b/sound/soc/intel/skylake/skl-messages.c
> @@ -483,6 +483,7 @@ static void skl_set_base_module_format(struct skl_sst *ctx,
>   	base_cfg->audio_fmt.bit_depth = format->bit_depth;
>   	base_cfg->audio_fmt.valid_bit_depth = format->valid_bit_depth;
>   	base_cfg->audio_fmt.ch_cfg = format->ch_cfg;
> +	base_cfg->audio_fmt.sample_type = format->sample_type;
>   
>   	dev_dbg(ctx->dev, "bit_depth=%x valid_bd=%x ch_config=%x\n",
>   			format->bit_depth, format->valid_bit_depth,
>