[alsa-devel] ChromeBook machine will lose MIC JD

[Kailang]

Hi Jaroslav,

I had modified the patch as you mentioned.
But I don't know how to use git send-email.

BR,
Kailang

-----Original Message-----
From: Jaroslav Kysela <perex at perex.cz> 
Sent: Friday, March 8, 2019 3:49 AM
To: Kailang <kailang at realtek.com>; Takashi Iwai (tiwai at suse.de) <tiwai at suse.de>
Cc: (alsa-devel at alsa-project.org) <alsa-devel at alsa-project.org>
Subject: Re: [alsa-devel] ChromeBook machine will lose MIC JD

Dne 07. 03. 19 v 9:11 Kailang napsal(a):
> Hi Jaroslav,
> 
> I need to check with Intel chrome audio team for the name change.
> But chrome OS used 'alc-sense-combo' for early patch file.

But with your patch, the ALC225_FIXUP_HEADSET_JACK and ALC295_FIXUP_CHROME_BOOK do a different thing, so it's not a simple replacement. Your chrome book fixup is not universal, so it should be distinguished in my opinion.

Also, please, inline your patches or use ;git send-email' command to send your commit to this ML for a review.

					Thanks,
						Jaroslav

> It also need to add this patch.
> 
> Oh! Sorry!
> I sent it with HTML mode.
> I need to resend again for TXT mode. 
> 
> BR,
> Kailang
> 
> -----Original Message-----
> From: Jaroslav Kysela <perex at perex.cz>
> Sent: Thursday, March 7, 2019 4:03 PM
> To: Kailang <kailang at realtek.com>; Takashi Iwai (tiwai at suse.de) 
> <tiwai at suse.de>
> Cc: (alsa-devel at alsa-project.org) <alsa-devel at alsa-project.org>
> Subject: Re: [alsa-devel] ChromeBook machine will lose MIC JD
> 
> Dne 07. 03. 19 v 8:56 Kailang napsal(a):
>> Hi Takashi,
>>
>> Attach patch will solve the issue for Mic JD lose.
>>
> 
> -	{.id = ALC225_FIXUP_HEADSET_JACK, .name = "alc-sense-combo"},
> +	{.id = ALC295_FIXUP_CHROME_BOOK, .name = "alc-sense-combo"},
> 
> Define another name here like 'alc-chrome-book' and don't remove the previous model name 'alc-sense-combo'.
> 
> 						Jaroslav
> 
> --
> Jaroslav Kysela <perex at perex.cz>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
> 
> ------Please consider the environment before printing this e-mail.
> 


--
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-chrome-headset-mic-jd.patch
Type: application/octet-stream
Size: 2364 bytes
Desc: 0002-chrome-headset-mic-jd.patch
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20190313/66ffc147/attachment.obj>