[alsa-devel] [PATCH 01/23] ASoC: atmel: atmel-pcm:dma.c: use devm_snd_dmaengine_pcm_register()

Codrin.Ciubotariu at microchip.com Codrin.Ciubotariu at microchip.com
Thu Jun 27 10:20:16 CEST 2019


On 27.06.2019 10:43, Amadeusz Sławiński wrote:
> External E-Mail
> 
> 
> On 27 Jun 2019 11:00:01 +0900
> Kuninori Morimoto <kuninori.morimoto.gx at renesas.com> wrote:
> 
>> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
>>
>> We have devm_xxx version of snd_dmaengine_pcm_register,
>> let's use it.
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
>> ---
>>   sound/soc/atmel/atmel-pcm-dma.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/sound/soc/atmel/atmel-pcm-dma.c
>> b/sound/soc/atmel/atmel-pcm-dma.c index 042e593..9abf072 100644
>> --- a/sound/soc/atmel/atmel-pcm-dma.c
>> +++ b/sound/soc/atmel/atmel-pcm-dma.c
>> @@ -111,13 +111,13 @@ static const struct snd_dmaengine_pcm_config
>> atmel_dmaengine_pcm_config = {
>>   int atmel_pcm_dma_platform_register(struct device *dev)
>>   {
>> -	return snd_dmaengine_pcm_register(dev,
>> &atmel_dmaengine_pcm_config, 0);
>> +	return devm_snd_dmaengine_pcm_register(dev,
>> +					&atmel_dmaengine_pcm_config,
>> 0); }
>>   EXPORT_SYMBOL(atmel_pcm_dma_platform_register);
>>   
>>   void atmel_pcm_dma_platform_unregister(struct device *dev)
>>   {
>> -	snd_dmaengine_pcm_unregister(dev);
>>   }
>>   EXPORT_SYMBOL(atmel_pcm_dma_platform_unregister);
>>   
> 
> Do we need to keep empty function?

Most probably not... Kuninori, let me know if you want me to remove 
atmel_pcm_dma_platform_unregister() from everywhere.

Thank you for your patch.

Best regards,
Codrin


More information about the Alsa-devel mailing list