[alsa-devel] [PATCH] sound: pci: emu10k1: Remove unneeded variable "change"

Takashi Iwai tiwai at suse.de
Sat Jul 13 19:44:17 CEST 2019


On Fri, 12 Jul 2019 10:06:23 +0200,
 Wasko, Michal  wrote:
> 
> 
> On 7/11/2019 7:17 PM, Hariprasad Kelam wrote:
> 
>     fix below issue reported by coccicheck
>     sound/pci/emu10k1/emu10k1x.c:1077:5-11: Unneeded variable: "change".
>     Return "0" on line 1092
>     
>     Signed-off-by: Hariprasad Kelam <hariprasad.kelam at gmail.com>
>     
> Since the  function always return 0 and you perform code clean-up then
> maybe it would be a good idea to just change function to void instead
> of returning int value which does not seem to have use.

No, it's a callback function.


Takashi


More information about the Alsa-devel mailing list