[alsa-devel] [PATCH 2/3] ALSA: aoa: Fix of-node refcount unbalance

Johannes Berg johannes at sipsolutions.net
Tue Feb 19 16:50:00 CET 2019


On Tue, 2019-02-19 at 16:31 +0100, Takashi Iwai wrote:
> We forgot to unreference a node obtained via of_find_node_by_name()
> after its usage.

How did you find this now?! Though I guess something like smatch could
find it, or even coccinelle?

> Only compile-tested.  Please review carefully.  Thanks!

Yes, looks right

Reviewed-by: Johannes Berg <johannes at sipsolutions.net>

I still have, but no longer run, the machine that uses this driver ...
anyone need a Powermac G5 quad? ;-)

johannes



More information about the Alsa-devel mailing list