[alsa-devel] [PATCH 2/3] ALSA: aoa: Fix of-node refcount unbalance

Takashi Iwai tiwai at suse.de
Tue Feb 19 16:31:23 CET 2019


We forgot to unreference a node obtained via of_find_node_by_name()
after its usage.

Signed-off-by: Takashi Iwai <tiwai at suse.de>
---

Only compile-tested.  Please review carefully.  Thanks!

 sound/aoa/core/gpio-feature.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/aoa/core/gpio-feature.c b/sound/aoa/core/gpio-feature.c
index 65557421fe0b..c3ff721e4660 100644
--- a/sound/aoa/core/gpio-feature.c
+++ b/sound/aoa/core/gpio-feature.c
@@ -82,6 +82,7 @@ static struct device_node *get_gpio(char *name,
 			if (altname && (strcmp(audio_gpio, altname) == 0))
 				break;
 		}
+		of_node_put(gpio);
 		/* still not found, assume not there */
 		if (!np)
 			return NULL;
-- 
2.16.4



More information about the Alsa-devel mailing list