[alsa-devel] [PATCH 1/2] ALSA: hda: hdmi - fix kernel oops caused by invalid PCM idx

Nikhil Mahale nmahale at nvidia.com
Mon Dec 2 05:44:53 CET 2019


Oh sorry again for this regression, Kai.

Originally my patches were developed with slightly older code which doesn't have your commit 2a2edfbbfee4 (ALSA: hda/hdmi - implement mst_no_extra_pcms flag), when I merge them with tot I did not notice codec->mst_no_extra_pcms mode.

This patch looks good to me.

Thanks,
Nikhil Mahale

On 11/29/19 8:13 PM, Takashi Iwai wrote:
> On Fri, 29 Nov 2019 15:37:55 +0100,
> Kai Vehmanen wrote:
>>
>> Add additional check in hdmi_find_pcm_slot() to not return
>> a pcm index that points to unallocated pcm. This could happen
>> if codec driver is set up in codec->mst_no_extra_pcms mode.
>> On some platforms, this leads to a kernel oops in snd_ctl_notify(),
>> called via update_eld().
>>
>> BugLink: https://github.com/thesofproject/linux/issues/1536
>> Fixes: 5398e94fb753 ALSA: hda - Add DP-MST support for NVIDIA codecs
>> Signed-off-by: Kai Vehmanen <kai.vehmanen at linux.intel.com>
> 
> Applied, thanks.
> 
> 
> Takashi
> 

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------


More information about the Alsa-devel mailing list