[alsa-devel] [PATCH v2 19/25] ASoC: soc-core: don't call snd_soc_component_set_jack()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Aug 29 02:16:08 CEST 2019


Hi Mark

> > I double-checked framework.
> > *All* drivers which are using snd_soc_component_set_jack()
> > doesn't care reset jack.
> > I think it should be done under driver, not framework,
> > but this patch seems have big effect.
> > OK, let's skip it.
> 
> Yes, I think the current code is better for robustness - we've got a few
> things like this where the core will do cleanup even if it's neater to
> do it in the driver since it makes it harder for there to be mistakes.

I agree we want to have robustness.
To make clear that it is for robustness,
I think it is better to have such message/comment on code :)

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list