[alsa-devel] [PATCH v2 19/25] ASoC: soc-core: don't call snd_soc_component_set_jack()

[Mark Brown]

On Tue, Aug 20, 2019 at 01:24:11PM +0900, Kuninori Morimoto wrote:

> > We can of course add handler to our driver to do this, first version of
> > patch actually did this, before we decided on global option.

> I double-checked framework.
> *All* drivers which are using snd_soc_component_set_jack()
> doesn't care reset jack.
> I think it should be done under driver, not framework,
> but this patch seems have big effect.
> OK, let's skip it.

Yes, I think the current code is better for robustness - we've got a few
things like this where the core will do cleanup even if it's neater to
do it in the driver since it makes it harder for there to be mistakes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20190828/457f263c/attachment.sig>