[alsa-devel] [PATCH 1/2] ASoC: AMD: Use single dai for da7219 playback and capture

[Agrawal, Akshu]

On 3/12/2018 10:31 PM, Mark Brown wrote:
> On Mon, Mar 12, 2018 at 02:41:22PM +0530, Akshu Agrawal wrote:
>> BT I2S is a bi-directional dai, we will use the same
>> cpu dai for playback and capture.
>>
>> TEST=Build, apply grunt_mixer_settings:
>> iotools mmio_write32 0xfed80e40 0x040c40c0
>> iotools mmio_write32 0xfed80e28 0x10000
>> aplay -D hw:0,0 -vv <file>
>> arecord -D hw:0,0 -f dat -d 5 -vv <file>
> 
> These reproduction instructions don't make much sense outside of your
> test environment (how is anyone supposed to know what
> grunt_mixer_settings is?).  I'm also rather worried about the random
> magic numbers you're using with this iowrite tool - what do they do?  It
> sounds like this driver might not work at all without some missing
> bit...
> 
write instructions are actually setting up the oscillator. These are 
being done in coreboot and patch is being pushed for same.
I will remove these noise from TEST field and submit again.