[alsa-devel] [PATCH 1/2] ASoC: AMD: Use single dai for da7219 playback and capture

[Mark Brown]

On Mon, Mar 12, 2018 at 02:41:22PM +0530, Akshu Agrawal wrote:
> BT I2S is a bi-directional dai, we will use the same
> cpu dai for playback and capture.
> 
> TEST=Build, apply grunt_mixer_settings:
> iotools mmio_write32 0xfed80e40 0x040c40c0
> iotools mmio_write32 0xfed80e28 0x10000
> aplay -D hw:0,0 -vv <file>
> arecord -D hw:0,0 -f dat -d 5 -vv <file>

These reproduction instructions don't make much sense outside of your
test environment (how is anyone supposed to know what
grunt_mixer_settings is?).  I'm also rather worried about the random
magic numbers you're using with this iowrite tool - what do they do?  It
sounds like this driver might not work at all without some missing
bit...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180312/b3c06b69/attachment.sig>