[alsa-devel] [PATCH] ASoC: pcm512x: Implement the digital_mute interface

Dimitris Papavasiliou dpapavas at gmail.com
Mon Dec 17 12:53:16 CET 2018


On 12/13/18 7:37 PM, Mark Brown wrote:
> That's not the end of the world, there's plenty of hardware that just
> doesn't physically have a way to mute in hardware at all and a software
> mute isn't particularly complex.

Removing the mute switch, is going to leave many users of DACs
with this CODEC driver without a way to mute their cards.  (I
know there are several boards for the Raspberry Pi platform
alone, some of which have external muting circuits, so they
wouldn't even experience any benefit from the patch.)  I'm not
sure how or where the software muting would be implemented, but
removing the switch would seem like a substantial inconvenience
at the very least, and I can't justify causing it (and deprive
the user of access to the hardware mute functionality of the
board), just to save a few relatively straightforward lines of
code.

That said, the patch seems to have been accepted, so now I'm
confused.  Do I have to make any changes to the patch, or is it
accepted as is?


More information about the Alsa-devel mailing list