[alsa-devel] [PATCH] ASoC: pcm512x: Implement the digital_mute interface

[Mark Brown]

On Mon, Nov 26, 2018 at 09:23:28PM +0200, Dimitris Papavasiliou wrote:
> On Mon, Nov 26, 2018 at 4:02 PM Mark Brown <broonie at kernel.org> wrote:

> > Just remove the control, no need to jump through these hoops.

>  Sorry, I probably misunderstand.  Do you propose removing
> the "Digital Playback Switch" control entirely?  It would

Yes.

> certainly simplify things, as far as implementing the
> .digital_mute callback is concerned, but it would remove the only
> way of manually muting the DAC.  The "Digital Playback Volume"
> control is the main (and basically sole, apart from a switchable
> -6dB analog gain control) volume control of the DAC and removing
> the Switch component would make it unmutable.

That's not the end of the world, there's plenty of hardware that just
doesn't physically have a way to mute in hardware at all and a software
mute isn't particularly complex.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20181213/70e4c3ac/attachment.sig>