[alsa-devel] [PATCH - hwmixvolume 1/9] hwmixvolume: replace PyGTK with gobject-introspection

[Emmanuel Gil Peyrot]

On Fri, Aug 10, 2018 at 04:56:47PM +0200, Takashi Iwai wrote:
> On Wed, 08 Aug 2018 17:56:29 +0200,
> Emmanuel Gil Peyrot wrote:
> > 
> > This doesn’t work yet, we require Gtk 3.0 rather than 2.0 and the API
> > changed quite a lot.
> > 
> > Signed-off-by: Emmanuel Gil Peyrot <linkmauve at linkmauve.fr>
> 
> Thanks for the patches.  Most of changes look good, but also most of
> patches have no change log at all.  That's already a bad sign.
> 
> Could you give some details, especially why the change is needed, in
> each patch and resubmit as a patchset?  At best, send with a cover
> letter and a thread as a patch set at the next time (git-send-email
> can manage it well).

I actually wrote a cover letter[1], but it seems your email service
didn’t accept the UTF-8 encoding of it, I received a bounce email about
that.

I’ll send a v2 with more detailed commit messages, thanks.

> 
> 
> Takashi

[1] https://linkmauve.fr/files/0000-cover-letter.patch

-- 
Emmanuel Gil Peyrot