[alsa-devel] [PATCH - hwmixvolume 1/9] hwmixvolume: replace PyGTK with gobject-introspection

Takashi Sakamoto o-takashi at sakamocchi.jp
Sat Aug 11 06:33:42 CEST 2018


Hi,

On Aug 10 2018 23:56, Takashi Iwai wrote:
> On Wed, 08 Aug 2018 17:56:29 +0200,
> Emmanuel Gil Peyrot wrote:
>>
>> This doesn’t work yet, we require Gtk 3.0 rather than 2.0 and the API
>> changed quite a lot.
>>
>> Signed-off-by: Emmanuel Gil Peyrot <linkmauve at linkmauve.fr>
> 
> Thanks for the patches.  Most of changes look good, but also most of
> patches have no change log at all.  That's already a bad sign.
> 
> Could you give some details, especially why the change is needed, in
> each patch and resubmit as a patchset?  At best, send with a cover
> letter and a thread as a patch set at the next time (git-send-email
> can manage it well).

I'm familiar with g-i. If you need reviewers, please add me to CC list 
in next time you post, freely.


Regards

Takashi Sakamoto


More information about the Alsa-devel mailing list