[alsa-devel] [PATCH] ALSA: hda: Abort capability probe on invalid capability

[Ughreja, Rakesh A]

>-----Original Message-----
>From: Takashi Iwai [mailto:tiwai at suse.de]
>Sent: Wednesday, October 18, 2017 3:50 PM
>To: Ughreja, Rakesh A <rakesh.a.ughreja at intel.com>
>Cc: alsa-devel at alsa-project.org; Koul, Vinod <vinod.koul at intel.com>
>Subject: Re: [PATCH] ALSA: hda: Abort capability probe on invalid capability
>
>On Wed, 18 Oct 2017 19:59:36 +0200,
>Ughreja, Rakesh A wrote:
>>
>> From: Rakesh Ughreja <rakesh.a.ughreja at intel.com>
>>
>> When an invalid capability is discovered, stop traversing
>> the capability link list further.
>
>Could you give more background, especially *why* we change that?
>It's almost clear what the patch does by looking at the change, but
>it's not clear why it is needed.

Is the following description in patch okay for you ?

Due to bugs in BIOS it's possible that the HDA capability link list is 
not constructed properly. This may lead to driver going into unknown
state. So whenever driver discovers unknown HDA capability, 
log it as error and stop traversing the link list further.

Regards,
Rakesh