[alsa-devel] [PATCH] ALSA: hda: Abort capability probe on invalid capability

[Takashi Iwai]

On Wed, 18 Oct 2017 19:59:36 +0200,
Ughreja, Rakesh A wrote:
> 
> From: Rakesh Ughreja <rakesh.a.ughreja at intel.com>
> 
> When an invalid capability is discovered, stop traversing
> the capability link list further.

Could you give more background, especially *why* we change that?
It's almost clear what the patch does by looking at the change, but
it's not clear why it is needed.


thanks,

Takashi


> Signed-off-by: Rakesh Ughreja <rakesh.a.ughreja at intel.com>
> ---
>  sound/hda/hdac_controller.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c
> index 978dc18..4fa0cc0 100644
> --- a/sound/hda/hdac_controller.c
> +++ b/sound/hda/hdac_controller.c
> @@ -314,7 +314,8 @@ int snd_hdac_bus_parse_capabilities(struct hdac_bus *bus)
>  			break;
>  
>  		default:
> -			dev_dbg(bus->dev, "Unknown capability %d\n", cur_cap);
> +			cur_cap = 0;
> +			dev_err(bus->dev, "Unknown capability %d\n", cur_cap);
>  			break;
>  		}
>  
> -- 
> 2.7.4
>