[alsa-devel] [PATCH 3/8] ASoC: ACPI: add new fields for SOF support

[Andy Shevchenko]

On Thu, 2017-10-12 at 18:49 -0500, Pierre-Louis Bossart wrote:

> - * @fw_filename: firmware file name.
> + * @fw_filename: firmware file name. Used when SOF is not enabled.

> + * @sof_fw_filename: Sound Open Firmware file name, if enabled
> + * @sof_tplg_filename: Sound Open Firmware topology file name, if
> enabled

Naming looks a bit awkward to me, though I would like to bring something
else here, i.e. unifying those firmwares somehow here.

It might be dealt with using two different (embedded) structs, e.g.

enum fw_type fw_type;
union {
 struct regular_fw fw;
 struct sof_fw sof;
}

It looks for me slightly cleaner to this struct than bring everything
inside it.

What do you think?

> +	const char *sof_fw_filename;
> +	const char *sof_tplg_filename;
> +	const char *asoc_plat_name;
> +	struct platform_device * (*new_mach_data)(void *pdata);

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy