[alsa-devel] [RFC PATCH 6/6] ASoC: sgtl5000: Don't disable regulators in SND_SOC_BIAS_OFF

Mark Brown broonie at kernel.org
Sat Mar 7 11:41:52 CET 2015


On Fri, Mar 06, 2015 at 03:35:36PM -0700, Eric Nelson wrote:
> On 03/06/2015 01:16 PM, Mark Brown wrote:

> > Why not just fix the code, reinitializing the chip is usually
> > pretty trivial?

> Apparently not.

Well, I'm not sure if that's actually true or not - the current driver
code is pretty bad and there's been a history of worrying submissions
that people assure me are working well and address problems.  All of
this is indicating to me that the complexity here is largely due to code
quality issues and that if we address those then things might get a lot
easier.

Requiring a funny power on sequence shouldn't be hard and is needed for
suspend and resume anyway, all having the regulator support does is mean
we can potentially take advantage of that code path at runtime.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150307/5643a518/attachment-0001.sig>


More information about the Alsa-devel mailing list