[alsa-devel] [RFC PATCH 6/6] ASoC: sgtl5000: Don't disable regulators in SND_SOC_BIAS_OFF

[Eric Nelson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Mark,

On 03/06/2015 01:16 PM, Mark Brown wrote:
> On Thu, Feb 26, 2015 at 03:54:33PM -0700, Eric Nelson wrote:
>> Disabling the SGTL5000 through regulators would certainly save 
>> power than simply disabling the reference voltages as described 
>> in the data sheet, but won't properly restore things on resume.
> 
> Why not just fix the code, reinitializing the chip is usually
> pretty trivial?
> 

Apparently not.

I think it's fair to say that nobody has hooked up switching regulators
using this driver, since they can't function without some form of this
patch set.

Once we have working regulator support, adding code to save power
additional power here might make sense, but not until then.

In other words, these are really elaborate no-ops now.

Regards,


Eric
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJU+iu4AAoJEFUqXmm9AiVrdlEH+gKLTIaT8ozcfbh1vgNWZQyz
lTd6wlMK9InRxZU2UPXtcCUIyK+z0YnNNoZEaoIP9YYLadOmpC+Gw/lF+8bAXInt
pEZqa17rLE7Q2xC1IhyjsIspQMP3Zpnvc/Ay51aq1I1M/wD4+G8kk6fhqrSAjBMo
DqYCNmP5AbLNGL1yePp/Zt5G/mgApC3QtE4vdBdi/4HIFxMNwySEmVFQD0/WV2aI
stZ8Sh5jc8pIQeLBRy1a0DJUF29jC7+nhVVMJQlXt8yWprnn6IgoM0dJTkzSif01
5HMRYLPbzemzJNOTcvIF15yOczGw4lqUmgbtR8Rz0wNQ3cghhjTk41HU5XasFJY=
=/NEm
-----END PGP SIGNATURE-----