[alsa-devel] [patch v2] ALSA: opl3: small array underflow
Dan Carpenter
dan.carpenter at oracle.com
Tue Mar 3 22:06:30 CET 2015
On Tue, Mar 03, 2015 at 09:59:17PM +0100, Clemens Ladisch wrote:
> Dan Carpenter wrote:
> > We don't check for negatives so "pitchbend" can be SHRT_MIN here. It
> > means that we can read up to 6 elements before the start of the
> > opl3_note_table[] array.
> >
> > There are several ways we could fix this. I have gone with what is
> > maybe the lazier approach of just changing negative values to zero.
>
> The lower bound is not zero but -8192.
Oh. I should have understood that from your previous email. Sorry for
that. Third time is lucky, I suppose.
regards,
dan carpenter
More information about the Alsa-devel
mailing list