[alsa-devel] [patch v2] ALSA: opl3: small array underflow

Clemens Ladisch clemens at ladisch.de
Tue Mar 3 21:59:17 CET 2015


Dan Carpenter wrote:
> We don't check for negatives so "pitchbend" can be SHRT_MIN here.  It
> means that we can read up to 6 elements before the start of the
> opl3_note_table[] array.
>
> There are several ways we could fix this.  I have gone with what is
> maybe the lazier approach of just changing negative values to zero.

The lower bound is not zero but -8192.


Regards,
Clemens


More information about the Alsa-devel mailing list