[alsa-devel] [PATCH v2] ASoC: ics43432: Add codec driver for InvenSense ICS-43432

[Mark Brown]

On Mon, Aug 17, 2015 at 09:48:11AM +0200, Lars-Peter Clausen wrote:

> Yes, I was. In my opinion this set_dai_fmt() implementation is useful to
> have as a mechanism to detect invalid configurations. E.g. if you don't
> implement the callback the CODEC will accept any setting while with he
> callback it will error out with the wrong configuration. Given that a I2S
> link typically at least somewhat works, even if you have the wrong setting,
> I think it makes sense to keep it to catch errors early on.

I agree that it's useful to catch such errors however I don't want to go
to implementing basically empty functions if we don't have to - we
should add the ability to specify capabilites in the DAI for the core to
check instead. 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150817/4dcc5f19/attachment.sig>