[alsa-devel] [PATCH v2] ASoC: ics43432: Add codec driver for InvenSense ICS-43432

[Ricard Wanderlof]

On Mon, 17 Aug 2015, Lars-Peter Clausen wrote:

> >>> +static int ics43432_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
> >>> +{
> >>> +	switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> >>
> >> This still seems redundant (IIRC Lars mentioned this...).
> > 
> > I though Lars was referring solely to the hw_params function, not 
> > set_dai_fmt, but of course I could have misunderstood him.
> 
> Yes, I was. In my opinion this set_dai_fmt() implementation is useful to
> have as a mechanism to detect invalid configurations. E.g. if you don't
> implement the callback the CODEC will accept any setting while with he
> callback it will error out with the wrong configuration. Given that a I2S
> link typically at least somewhat works, even if you have the wrong setting,
> I think it makes sense to keep it to catch errors early on.

Makes sense to me. 

Ok, then, unless Mark seriously objects, I'll leave this as it is, and
resubmit the patch with a revised MODULE_LICENSE string and repartitioning
of the commit message / version comment.

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30