[alsa-devel] [PATCH v4] ALSA: Add SoC on-chip internal memory support for DMA buffer allocation

[Lars-Peter Clausen]

On 10/16/2013 01:58 PM, Mark Brown wrote:
> On Wed, Oct 16, 2013 at 06:53:21PM +0800, Nicolin Chen wrote:
> 
>> +	if (!dev->of_node)
>> +		return NULL;
>> +
>> +	pool = of_get_named_gen_pool(dev->of_node, "iram", 0);
>> +	if (!pool)
>> +		return NULL;
> 
> Can you refactor these ifdefs so they just protect this OF specific code
> and just have the allocation fail otherwise please?  That way the OF
> dependency is minimised - we should be able to support this on other
> platforms in the future and the rest of the code will be the same.
> 
> Also is iram the best name?  It makes me think of the dedicated fast
> instruction RAM that some processors have.  sram perhaps (for static
> RAM)?

Using IRAM (internal SRAM) for this seems to be quite popular (`grep IRAM
arch/arm -r`). Existing devicetree bindings also seem to use the 'iram'
property to refer to the on-chip SRAM
(Documentation/devicetree/bindings/media/coda.txt). It's probably a good
idea to stay consistent with the existing bindings.

- Lars