[alsa-devel] [PATCH v4] ALSA: Add SoC on-chip internal memory support for DMA buffer allocation

[Chen Guangyu-B42378]

Okay,  I will try to refine it tomorrow.

Thank you for the comments.

Sent by Android device.

Mark Brown <broonie at kernel.org> wrote:


On Wed, Oct 16, 2013 at 06:53:21PM +0800, Nicolin Chen wrote:

> +     if (!dev->of_node)
> +             return NULL;
> +
> +     pool = of_get_named_gen_pool(dev->of_node, "iram", 0);
> +     if (!pool)
> +             return NULL;

Can you refactor these ifdefs so they just protect this OF specific code
and just have the allocation fail otherwise please?  That way the OF
dependency is minimised - we should be able to support this on other
platforms in the future and the rest of the code will be the same.

Also is iram the best name?  It makes me think of the dedicated fast
instruction RAM that some processors have.  sram perhaps (for static
RAM)?