[alsa-devel] [PATCH 1/2] ASoC: fsi: add device tree support

[Kuninori Morimoto]

Hi Mark

Thank you for checking patch

> > +- fsia,flags : FSI-A flags [spdif/cpg/stream]
> > +- fsia,tx_id : FSI-A DMAEngine ID if needed
> > +- fsib,flags : FSI-B flags [spdif/cpg/stream]
> > +- fsib,tx_id : FSI-B DMAEngine ID if needed
> 
> The flags should be documented - what do these flags mean?  The
> DMAEngine stuff is a bit fun but I don't think there's yet been any
> resolution of what to do with DMAEngine in DT yet...

I see. v2 will be
 - add document for flags
 - remove DMAEngine setting

> > +		{ "cpg",	SH_FSI_CLK_CPG },
> 
> Is this definitely something that would be fixed by hardware design?
> 
> > +		{ "stream",	SH_FSI_ENABLE_STREAM_MODE },
> 
> Why wouldn't stream mode be desired?

Thanks.
It will be more descriptive name in v2


Best regards
---
Kuninori Morimoto