[alsa-devel] [PATCH 1/2] ASoC: fsi: add device tree support

[Mark Brown]

On Thu, Dec 27, 2012 at 07:15:19PM -0800, Kuninori Morimoto wrote:

> +- fsia,flags : FSI-A flags [spdif/cpg/stream]
> +- fsia,tx_id : FSI-A DMAEngine ID if needed
> +- fsib,flags : FSI-B flags [spdif/cpg/stream]
> +- fsib,tx_id : FSI-B DMAEngine ID if needed

The flags should be documented - what do these flags mean?  The
DMAEngine stuff is a bit fun but I don't think there's yet been any
resolution of what to do with DMAEngine in DT yet...

> +FSI needs simple-card driver. see also simple-card.txt

This isn't true, the driver can be used with any machine driver.  It's
true that many machines using the FSI driver can be supported with the
simple-card driver but others are also fine.

> +		{ "cpg",	SH_FSI_CLK_CPG },

Is this definitely something that would be fixed by hardware design?

> +		{ "stream",	SH_FSI_ENABLE_STREAM_MODE },

Why wouldn't stream mode be desired?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130103/c5904d37/attachment.sig>