[alsa-devel] [PATCH - [hdspm] 1/3] Add headers for RayDAT and AIO support.

[Adrian Knoth]

On Tue, Jan 18, 2011 at 03:40:21PM +0100, Takashi Iwai wrote:

> Adrian Knoth wrote:
> > 
> > +struct hdspm_peak_rms {
> > +		uint32_t input_peaks[64];
> > +		uint32_t playback_peaks[64];
> > +		uint32_t output_peaks[64];
> Strange indentation level?

Indeed. Fixed.

> > +struct hdspm_status {
> > +	hdspm_io_type card_type;
> > +	hdspm_syncsource autosync_source;
> > +
> > +	unsigned long long card_clock;
> Use more explicit int type with bit width.

Done.

> > +static char *texts_sync_status[] = {
> > +	"no lock",
> > +	"lock",
> > +	"sync"
> > +};
> 
> Put these to *.c.

Looks like this array is actually unused. Let's see which of them can be
dropped or moved to *.c.

I'll have to cross-check with hdspmixer, some parts are referenced
there.


Cheers

-- 
mail: adi at thur.de  	http://adi.thur.de	PGP/GPG: key via keyserver