[alsa-devel] [PATCH - [hdspm] 1/3] Add headers for RayDAT and AIO support.

[Takashi Iwai]

At Tue, 18 Jan 2011 15:12:17 +0100,
Adrian Knoth wrote:
> 
> +struct hdspm_peak_rms {
> +		uint32_t input_peaks[64];
> +		uint32_t playback_peaks[64];
> +		uint32_t output_peaks[64];

Strange indentation level?

> +struct hdspm_status {
> +	hdspm_io_type card_type;
> +	hdspm_syncsource autosync_source;
> +
> +	unsigned long long card_clock;

Use more explicit int type with bit width.

> +static char *texts_sync_status[] = {
> +	"no lock",
> +	"lock",
> +	"sync"
> +};

Put these to *.c.


Takashi