[alsa-devel] [PATCH 2/2] ASoC: da7210: Add 11025/22050/44100/88200 rate support

[Kuninori Morimoto]

Dear Mark

Thank you for checking patch

> >  	snd_soc_update_bits(codec, hpf_reg, hpf_mask, hpf_value);
> >  	snd_soc_update_bits(codec, DA7210_PLL, DA7210_PLL_FS_MASK, fs);
> > +	snd_soc_update_bits(codec, DA7210_PLL_DIV3, DA7210_PLL_BYP, bypass);
> 
> This will take effect for both playback and capture - what happens if
> one mode wants bypass and another doesn't?  Does the device actually
> support asymmetric sample rates?

This chip doesn't support asymmetric sample rates.
Is there a method of prohibiting it on ALSA ?
Or should I add any lock ?

> > +	/* As suggested by Dialog */
> > +	da7210_write(codec, DA7210_A_HID_UNLOCK,	0x8B);
> > +	da7210_write(codec, DA7210_A_TEST_UNLOCK,	0xB4);
> > +	da7210_write(codec, DA7210_A_PLL1,		0x01);
> > +	da7210_write(codec, DA7210_A_CP_MODE,		0x7C);
> 
> I suspect you want to disable the HID and test keys when you're done
> fiddling with the configuration here...

Ohh sorry.
This XXX_UNLOCK doesn't mean "disable"..
In default, we can not change value on some register
because it is locked.
So, this driver unlock it here.

Should I add some comment ?

Best regards
--
Kuninori Morimoto