[alsa-devel] [PATCH 2/2] ASoC: da7210: Add 11025/22050/44100/88200 rate support

[Mark Brown]

On Tue, Mar 02, 2010 at 05:13:50PM +0900, Kuninori Morimoto wrote:

> +	/* Disable active mode */
> +	snd_soc_update_bits(codec, DA7210_STARTUP1, DA7210_SC_MST_EN, 0);
> +
>  	snd_soc_update_bits(codec, hpf_reg, hpf_mask, hpf_value);
>  	snd_soc_update_bits(codec, DA7210_PLL, DA7210_PLL_FS_MASK, fs);
> +	snd_soc_update_bits(codec, DA7210_PLL_DIV3, DA7210_PLL_BYP, bypass);

This will take effect for both playback and capture - what happens if
one mode wants bypass and another doesn't?  Does the device actually
support asymmetric sample rates?

> +	/* As suggested by Dialog */
> +	da7210_write(codec, DA7210_A_HID_UNLOCK,	0x8B);
> +	da7210_write(codec, DA7210_A_TEST_UNLOCK,	0xB4);
> +	da7210_write(codec, DA7210_A_PLL1,		0x01);
> +	da7210_write(codec, DA7210_A_CP_MODE,		0x7C);

I suspect you want to disable the HID and test keys when you're done
fiddling with the configuration here...