[alsa-devel] [PATCH] alsa: Emagic Audiowerk8 low-level ALSA driver

[Takashi Iwai]

[please stop top-posting]

At Wed, 8 Oct 2008 16:32:40 +0000 (GMT),
matthias.nyffenegger at bluewin.ch wrote:
> 
> straight-forward implementation - with focus on AW2 - and does not 
> provide generic code parts (apart saa7146 register addr. definitions) 
> for reuse. Maybe that's why it has its own directory not named after
> the chipset?

Maybe yes, maybe not...

> Besides that I have put much emphasis on providing an abstraction-layer
> for saa7146 chipset audio functionality, on top of which the audiowerk
> specific stuff is built. Hence it does not make much sense to me trying
> to reuse code of the existing AW2 driver.

I don't care in which direction, whether to merge yours into aw2 or
aw2 into yours.  I just want to have a reasonable merge of two
works.

Well, this is basically an option, and can be achieved later, too.
So, could you post the patches to ML for further reviews?

But before submitting patches, I recommend you to run once
scripts/checkpatch.pl (found in kernel tree) with your patches.
You'll find lots of coding style issues even by such a simple tool.
Then, check Documentation/CodingStyle and fix your codes again.

And, please remove the debug trace stuff unless you really need it in
future.  This decreases readability fairly much.


thanks,

Takashi


> I hope you see my point and would appreciate your opinion on this.



> 
> regards, 
> 
> Matthias
> 
> ----Ursprüngliche Nachricht----
> Von: tiwai at suse.de
> Datum: 19.09.2008 17:55
> An: <matthias.nyffenegger at bluewin.ch>
> Kopie: "Cedric Bregardis"<cedric.bregardis at free.fr>, "Jean-Christian Hassler"<jhassler at free.fr>, <alsa-devel at alsa-
> project.org>
> Betreff: Re: [PATCH] alsa: Emagic Audiowerk8 low-level ALSA driver
> 
> At Fri, 19 Sep 2008 09:10:00 +0000 (GMT),
> matthias.nyffenegger at bluewin.ch wrote:
> > 
> > From: Matthias Nyffenegger <matthias.nyffenegger at bluewin.ch>
> > 
> > Low-level ALSA driver for Emagic Audiowerk8 sound card.
> > Project page: