[alsa-devel] [PATCH] alsa: Emagic Audiowerk8 low-level ALSA driver

[matthias.nyffenegger at bluewin.ch]

Hi Takashi,

Thank you for your quick answer, I am not that fast ;-)

>At the next time, it'd be appreciate if you post the patch itself,
>then we can review and give comments on the code in a reply.
>Even if it's too big, you can split to several pieces.

Ok.

>Just checking it now, and soon found out that many components look
>similar as AW2.  We have already AW2 driver (whose authors cc'ed).
>Can you reuse the code?

Hm, I'm afraid not at his point. The existing AW2 driver is IMHO a very
straight-forward implementation - with focus on AW2 - and does not 
provide generic code parts (apart saa7146 register addr. definitions) 
for reuse. Maybe that's why it has its own directory not named after
the chipset?
Besides that I have put much emphasis on providing an abstraction-layer
for saa7146 chipset audio functionality, on top of which the audiowerk
specific stuff is built. Hence it does not make much sense to me trying
to reuse code of the existing AW2 driver.

I hope you see my point and would appreciate your opinion on this.

regards, 

Matthias

----Ursprüngliche Nachricht----
Von: tiwai at suse.de
Datum: 19.09.2008 17:55
An: <matthias.nyffenegger at bluewin.ch>
Kopie: "Cedric Bregardis"<cedric.bregardis at free.fr>, "Jean-Christian Hassler"<jhassler at free.fr>, <alsa-devel at alsa-
project.org>
Betreff: Re: [PATCH] alsa: Emagic Audiowerk8 low-level ALSA driver

At Fri, 19 Sep 2008 09:10:00 +0000 (GMT),
matthias.nyffenegger at bluewin.ch wrote:
> 
> From: Matthias Nyffenegger <matthias.nyffenegger at bluewin.ch>
> 
> Low-level ALSA driver for Emagic Audiowerk8 sound card.
> Project page: http://sourceforge.net/projects/aw8-alsa

First off, thanks for your patch.

At the next time, it'd be appreciate if you post the patch itself,
then we can review and give comments on the code in a reply.
Even if it's too big, you can split to several pieces.

> Built and tested with Vanilla 2.6.25.16, ALSA 1.0.14a.
> 
> Signed-off-by: Matthias Nyffenegger <matthias.nyffenegger at bluewin.ch>
> ---
> This is a request for submission to ALSA-tree.
> URL: http://downloads.sourceforge.net/aw8-alsa/aw-alsa-patch-0.2

Just checking it now, and soon found out that many components look
similar as AW2.  We have already AW2 driver (whose authors cc'ed).
Can you reuse the code?


thanks,

Takashi