[alsa-devel] [PATCH 2.6.25.1] S3C2410 pcm audio broken

[Liam Girdwood]

On Sun, 2008-05-04 at 14:57 +0200, ing. Davide Rizzo wrote:
> S3C2410 pcm doesn't work.
> s3c2410_dma_request() now returns the channel number and not 0 if OK.
> Davide
> plain text document attachment (s3c24xx-pcm.patch)
> This patch to update to a s3c2410_dma_request return value change
> 
> Signed-off-by: Davide Rizzo <davide at elpa.it>
> ================================================================================
> --- linux-2.6.25.1/sound/soc/s3c24xx/s3c24xx-pcm.c	2008-04-17 04:49:44.000000000 +0200
> +++ linux-2.6.25.1.elpa/sound/soc/s3c24xx/s3c24xx-pcm.c	2008-05-04 09:27:46.000000000 +0200
> @@ -171,7 +171,7 @@ static int s3c24xx_pcm_hw_params(struct 
>  		ret = s3c2410_dma_request(prtd->params->channel,
>  					  prtd->params->client, NULL);
>  
> -		if (ret) {
> +		if (ret < 0) {
>  			DBG(KERN_ERR "failed to get dma channel\n");
>  			return ret;
>  		}
> -------------------------------------------------------------------

Acked-by: Liam Girdwood <lg at opensource.wolfsonmicro.com>