[alsa-devel] [PATCH 2.6.25.1] S3C2410 i2s programming error

[Liam Girdwood]

On Sun, 2008-05-04 at 15:00 +0200, ing. Davide Rizzo wrote:
> S3C2410 i2s driver currently manages only i2s protocol (and not left 
> justified one) and slave mode.
> With this small patch, other modes are possible.
> Davide
> 
> 
> plain text document attachment (s3c24xx-i2s.patch)
> This patch to correctly manage codecs in slave mode and left-justified format
> 
> Signed-off-by: Davide Rizzo <davide at elpa.it>
> ================================================================================
> --- linux-2.6.25.1/sound/soc/s3c24xx/s3c24xx-i2s.c	2008-04-17 04:49:44.000000000 +0200
> +++ linux-2.6.25.1.elpa/sound/soc/s3c24xx/s3c24xx-i2s.c	2008-05-04 09:23:34.000000000 +0200
> @@ -224,6 +224,7 @@ static int s3c24xx_i2s_set_fmt(struct sn
>  		iismod |= S3C2410_IISMOD_SLAVE;
>  		break;
>  	case SND_SOC_DAIFMT_CBS_CFS:
> +		iismod &= ~S3C2410_IISMOD_SLAVE;
>  		break;
>  	default:
>  		return -EINVAL;
> @@ -234,6 +235,7 @@ static int s3c24xx_i2s_set_fmt(struct sn
>  		iismod |= S3C2410_IISMOD_MSB;
>  		break;
>  	case SND_SOC_DAIFMT_I2S:
> +		iismod &= ~S3C2410_IISMOD_MSB;
>  		break;
>  	default:
>  		return -EINVAL;
> -------------------------------------------------------------------

Acked-by: Liam Girdwood <lg at opensource.wolfsonmicro.com>