[alsa-devel] [PATCH] tlv320aic3x: control additions and cleanups

[Mark Brown]

On Fri, Dec 05, 2008 at 03:21:39PM +0200, Jarkko Nikula wrote:
> On Fri, Dec 5, 2008 at 3:00 PM, Mark Brown <broonie at sirena.org.uk> wrote:
> > On Fri, Dec 05, 2008 at 02:45:04PM +0200, Jarkko Nikula wrote:

> > > 54f01916297bafc18bd7df4e2300a0544a84fce3? Change like

> > Several codecs do this - systems often end up doing things like using
> > the line inputs as unrelated mono paths rather than as a stereo path.
> > How likely that is to happen with this codec I don't know.

> Or did I read the idea of patch wrong? Before there were stereo contol for

> PGAL -> HPL
> PGAR -> HPR

> and now

> PGAL -> HPL
> PGAL -> HPR

> PGAR seems to be missing?

Hrm.  This looks like it just substitutes two single controls for one
stereo control, which seems reasonable and shouldn't loose any control:

> -       SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
> -                    PGAR_2_HPROUT_VOL, 0, 0x7f, 1),
> +       SOC_SINGLE("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
> +                    0, 0x7f, 1),
> +       SOC_SINGLE("HPR PGA Bypass Playback Volume", PGAL_2_HPROUT_VOL,
> +                    0, 0x7f, 1),

Possibly the controls are mislabeled?

Daniel?