[alsa-devel] [PATCH] tlv320aic3x: control additions and cleanups

[Daniel Mack]

On Fri, Dec 05, 2008 at 01:42:58PM +0000, Mark Brown wrote:
> > > On Fri, Dec 05, 2008 at 02:45:04PM +0200, Jarkko Nikula wrote:
> > and now
> 
> > PGAL -> HPL
> > PGAL -> HPR
> 
> > PGAR seems to be missing?
> 
> Hrm.  This looks like it just substitutes two single controls for one
> stereo control, which seems reasonable and shouldn't loose any control:
> 
> > -       SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
> > -                    PGAR_2_HPROUT_VOL, 0, 0x7f, 1),
> > +       SOC_SINGLE("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
> > +                    0, 0x7f, 1),
> > +       SOC_SINGLE("HPR PGA Bypass Playback Volume", PGAL_2_HPROUT_VOL,
> > +                    0, 0x7f, 1),
> 
> Possibly the controls are mislabeled?

We could call them "HPR PGA left Bypass Playback Volume" and "HPR PGA
right Bypass Playback Volume" to be more precise.

Daniel