[alsa-devel] [PATCH 1/3] asoc tlv320aic3x: revisit clock setup

[Jarkko Nikula]

2008/4/25 Daniel Mack <daniel at caiaq.org>:

> On Fri, Apr 25, 2008 at 11:28:44AM +0200, Takashi Iwai wrote:
> > > +#define ABS(x) (((x) >= 0) ? (x) : -(x))
> >
> > We already have a standard abs() in linux/kernel.h.
>
> Ok, thanks for mentioning that. See the patch below. Also bumped the
> version number here.
>
> Did you forgot to take into account doubled fsref below (from the first
version) when calculating codec_clk because now it is doubled earlier?

+    codec_clk = (2048 * fsref) / (aic3x->sysclk / 1000);
+
+    if (params_rate(params) >= 88200)
+        fsref *= 2;

There should not be dead code like

+        /* printk(KERN_INFO "%s(): bypassing PLL with Q=%d\n",
+            __func__, pll_q); */

I forgot to mention in my previous comment that KERN_DEBUG would be better
here or just remove the printk.


Jarkko