[alsa-devel] [PATCH 1/3] asoc tlv320aic3x: revisit clock setup

Takashi Iwai tiwai at suse.de
Fri Apr 25 11:43:27 CEST 2008


At Fri, 25 Apr 2008 11:36:57 +0200,
Daniel Mack wrote:
> 
> On Fri, Apr 25, 2008 at 11:28:44AM +0200, Takashi Iwai wrote:
> > > diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
> > > index 630684f..87e5040 100644
> > > --- a/sound/soc/codecs/tlv320aic3x.c
> > > +++ b/sound/soc/codecs/tlv320aic3x.c
> > > @@ -51,6 +51,8 @@
> > >  #define AUDIO_NAME "aic3x"
> > >  #define AIC3X_VERSION "0.1"
> > >  
> > > +#define ABS(x) (((x) >= 0) ? (x) : -(x))
> > 
> > We already have a standard abs() in linux/kernel.h.
> 
> Ok, thanks for mentioning that. See the patch below. Also bumped the
> version number here.

You don't need to include <linux/kernel.h> there.  It's almost always
included.


Takashi


More information about the Alsa-devel mailing list