On 12.05.2018 08:01, Ranjani Sridharan wrote:
On Fri, 2018-05-11 at 17:03 +0300, Seppo Ingalsuo wrote:
+#if defined MODULE_TEST +#include <stdio.h> +#endif
Are the MODULE_TEST bits in the code for ci tests?
Yes for myself, generally maybe. I used the output that's generated with MODULE_TEST to compare the HW registers programming to the setup that the closed Intel firmware version does. I use a hacked test bench version to run the DAI component up to capture start event.
Today or in near future it's not possible to have this in CI since the DAI component gets replaced by the file I/O component in the test pipelines. Though the test bench could run this driver (or SSP) up to capture start and then switch into file I/O based capture/playback simulation. But there's more work that likely couldn't make it to the next SOF release so better to not target it yet.
I could keep the test code or delete it for now as you prefer. Something like that would be useful if we in future would like to module test / unit test partially drivers code this way.
Thanks, Seppo