- Sound-open-firmware - mailman.alsa-project.org

[Sound-open-firmware] cache invalidation evicting wrong lines
by Guennadi Liakhovetski 18 Mar '19

18 Mar '19

Hi, Working on https://github.com/thesofproject/sof/pull/1053 I'm making sure all the DSP cores see the same data, which on Xtensa seems to require manual cache synchronisation. This is a painful task, it's actually even only practically possible because there aren't many objects in SOF that can be accessed by different cores. However, with that PR interrupt descriptors will also become accessible by multiple cores. On Sue Creek there are two kinds of cascading interrupt controllers: internal "level2" - "level5" and a DesignWare interrupt controller IP, used by several peripherals, uncliding the UART. With the addition of manual cache synchronisation UART interrupts stopped working. Debugging showed, that DW INTC interrupt descriptors lose their updates when other descriptors have their cache invalidated. And those descriptors aren't even immediately close to each other in RAM. Roughly the following is happening: dw_intc->irq = new_irq; list_for_item(list, descriptors) { desc = container_of(list, struct irq_desc, list); dcache_invalidate_region(desc, sizeof(*desc)); at which point dw_intc->irq loses its new_irq value and restores the initial -EINVAL value. If I either remove the invalidation line above or add a writeback for dw_intc between the first two lines, the problem goes away. Therefore questions: 1. am I using cache invalidation wrongly? 2. if the invalidated memory region isn't cache-line aligned, what happens then? Are all full lines invalidated, thus potentially erasing data? But even if this were handled wrongly, it wouldn't cause this problem, because those descriptors aren't adjacent in RAM. 3. is that a software or a hardware bug? 4. how to fix? Thanks Guennadi

2 7

[Sound-open-firmware] MinnowBoard FW fails to boot
by Guennadi Liakhovetski 11 Mar '19

11 Mar '19

Hi, Is MinnowBoard supposed to work with the current sources? I tried 2 boards: an older Max and a new Turbot with the same result. After upgrading the BIOS to 1.0 and configuring it as described on https://thesofproject.github.io/latest/getting_started/setup/setup_minnowbo… and installing the ACPI scripts, I see the following in dmesg: [ 7.858284] sof-audio-acpi 80860F28:01: ACPI DSP detected [ 7.858293] sof-audio-acpi 80860F28:01: BYT-CR not detected [ 7.858417] sof-audio-acpi 80860F28:01: probing SOF DSP device.... [ 7.858437] sof-audio-acpi 80860F28:01: sof_probe_work entry [ 7.858442] sof-audio-acpi 80860F28:01: LPE PHY base at 0x90a00000 size 0x200000 [ 7.858495] sof-audio-acpi 80860F28:01: LPE VADDR 000000005df3cd39 [ 7.858498] sof-audio-acpi 80860F28:01: IMR base at 0x20000000 size 0x100000 [ 7.858525] sof-audio-acpi 80860F28:01: IMR VADDR 00000000c1d6001c [ 7.858530] sof-audio-acpi 80860F28:01: using IRQ 29 [ 7.861914] sof-audio-acpi 80860F28:01: loading firmware [ 7.903934] sof-audio-acpi 80860F28:01: header size=0xc9a4 modules=0x1 abi=0x1 size=16 [ 7.903980] sof-audio-acpi 80860F28:01: new module size 0xc998 blocks 0x11 type 0x0 [ 7.903984] sof-audio-acpi 80860F28:01: block 0 type 0x1 size 0xf0 ==> offset 0xc0000 [ 7.904148] sof-audio-acpi 80860F28:01: block 1 type 0x1 size 0x16c ==> offset 0xc0400 [ 7.904454] sof-audio-acpi 80860F28:01: block 2 type 0x1 size 0x8 ==> offset 0xc057c [ 7.904461] sof-audio-acpi 80860F28:01: block 3 type 0x1 size 0x8 ==> offset 0xc059c [ 7.904468] sof-audio-acpi 80860F28:01: block 4 type 0x1 size 0x8 ==> offset 0xc05bc [ 7.904475] sof-audio-acpi 80860F28:01: block 5 type 0x1 size 0x8 ==> offset 0xc05dc [ 7.904481] sof-audio-acpi 80860F28:01: block 6 type 0x1 size 0x8 ==> offset 0xc05fc [ 7.904488] sof-audio-acpi 80860F28:01: block 7 type 0x1 size 0x4 ==> offset 0xc061c [ 7.904492] sof-audio-acpi 80860F28:01: block 8 type 0x1 size 0x8 ==> offset 0xc063c [ 7.904498] sof-audio-acpi 80860F28:01: block 9 type 0x1 size 0x4 ==> offset 0xc0658 [ 7.904502] sof-audio-acpi 80860F28:01: block 10 type 0x1 size 0x18 ==> offset 0xc065c [ 7.904522] sof-audio-acpi 80860F28:01: block 11 type 0x1 size 0x8 ==> offset 0xc067c [ 7.904529] sof-audio-acpi 80860F28:01: block 12 type 0x1 size 0xad20 ==> offset 0xc06a0 [ 7.942341] sof-audio-acpi 80860F28:01: block 13 type 0x2 size 0xc34 ==> offset 0x100008 [ 7.945002] sof-audio-acpi 80860F28:01: block 14 type 0x2 size 0x8 ==> offset 0x100c3c [ 7.945009] sof-audio-acpi 80860F28:01: block 15 type 0x2 size 0xc50 ==> offset 0x100c48 [ 7.947695] sof-audio-acpi 80860F28:01: block 16 type 0x2 size 0x6c ==> offset 0x101f20 [ 7.947797] sof-audio-acpi 80860F28:01: booting DSP firmware [ 7.993488] intel_rapl: Found RAPL domain package [ 7.993491] intel_rapl: Found RAPL domain core [ 9.037666] sof-audio-acpi 80860F28:01: error: unable to run DSP firmware [ 9.038008] sof-audio-acpi 80860F28:01: error: unexpected fault 0xffffffff trace 0xffffffff [ 9.038094] sof-audio-acpi 80860F28:01: error: failed to reset DSP [ 9.038159] sof-audio-acpi 80860F28:01: error: failed to boot DSP firmware -19 [ 9.038266] sof-audio-acpi 80860F28:01: error: sof_probe_work failed err: -19 Thanks Guennadi

3 3

[Sound-open-firmware] checkpatch.pl fixes
by Daniel Baluta 04 Mar '19

04 Mar '19

Hi all, What is your take on checkpatch.pl fixes for SOF FW? Diana (CC'ed) is trying to get accustomed with SOF code and while at that she can fix some obvious checkpatch.pl warn / errors. Does it make sense to send some patches for that? I know that this kind of fixes can pollute the change history but on the other side code gets a little bit cleaner. thanks, Daniel.

3 3

Re: [Sound-open-firmware] help with unit tests
by Wilson, Danny 28 Feb '19

28 Feb '19

Hello, I am a new user from VeriSilicon, also trying to get unit tests to run. Thanks for bringing this project to GitHub. On 2/8/19 1:06 PM Jankowski, Janusz wrote: > TL;DR: Unit Tests are not supported for xtensa GCC toolchains at the moment (work in progress). You can run them only with xtensa xt-* toolchain that provides simulator (xt-run). On 2/8/19 8:24 PM, Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com worte: > FWIW, there is an alternate way of getting everything in one shot with > 'repo', there are build-scripts provided so that you can reproduce the > same setup as other developers. > > repo init -u https://github.com/thesofproject/sof-manifests > > repo sync -c My environment is: Ubuntu 18.04.2 LTS When trying the alternate method described by Pierre, I get the following permission denied error: ~/work/sof$ repo init -u https:://github.com/thesofproject/sof-manifests Traceback (most recent call last): File "/home/us9005/work/sof/.repo/repo/main.py", line 40, in <module> import event_log File "/home/us9005/work/sof/.repo/repo/event_log.py", line 165, in <module> _EVENT_ID = multiprocessing.Value('i', 1) File "/snap/git-repo/18/usr/lib/python2.7/multiprocessing/__init__.py", line 253, in Value return Value(typecode_or_type, *args, **kwds) File "/snap/git-repo/18/usr/lib/python2.7/multiprocessing/sharedctypes.py", line 108, in Value lock = RLock() File "/snap/git-repo/18/usr/lib/python2.7/multiprocessing/__init__.py", line 183, in RLock return RLock() File "/snap/git-repo/18/usr/lib/python2.7/multiprocessing/synchronize.py", line 172, in __init__ SemLock.__init__(self, RECURSIVE_MUTEX, 1, 1) File "/snap/git-repo/18/usr/lib/python2.7/multiprocessing/synchronize.py", line 75, in __init__ sl = self._semlock = _multiprocessing.SemLock(kind, value, maxvalue) OSError: [Errno 13] Permission denied Is this a repository permission I am lacking? Is there a particular build-script that includes the xtensa-xt* toolchain for unit tests? Regards, Danny Wilson

2 1

[Sound-open-firmware] [PATCH] topology: ssp: add polarity inversion option in SSP_CLOCK
by Dragos Tarcatu 25 Feb '19

25 Feb '19

alsatplg allows setting inverted bclk and fsync polarities by setting either bclk_invert or fsync_invert to "true". This patch adds a default parameter in the SSP_CLOCK m4 macro which allows setting inverted bclk and fsync polarities. Signed-off-by: Dragos Tarcatu <dragos_tarcatu(a)mentor.com> --- tools/topology/platform/common/ssp.m4 | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/topology/platform/common/ssp.m4 b/tools/topology/platform/common/ssp.m4 index f3c7862..76b2766 100644 --- a/tools/topology/platform/common/ssp.m4 +++ b/tools/topology/platform/common/ssp.m4 @@ -2,11 +2,12 @@ divert(-1) dnl SSP related macros -dnl SSP_CLOCK(clock, freq, codec_master) +dnl SSP_CLOCK(clock, freq, codec_master, polarity) +dnl polarity is optional define(`SSP_CLOCK', $1 STR($3) - $1_freq STR($2)) - + $1_freq STR($2) + `ifelse($4, `inverted', `$1_invert "true"',`')') dnl SSP_TDM(slots, width, tx_mask, rx_mask) define(`SSP_TDM', -- 2.7.4

2 1

Re: [Sound-open-firmware] [alsa-devel] [v4, 00/14] ASoC: Sound Open Firmware (SOF) core
by xiang xiao 25 Feb '19

25 Feb '19

On Tue, Feb 19, 2019 at 5:49 PM Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> wrote: > > > > On 18/02/2019 20:03, Xiang Xiao wrote: > > Should we utilize official IPC frameowrk instead reinverting the wheel? > > 1.Load firmware by drivers/remoteproc > > https://www.kernel.org/doc/Documentation/remoteproc.txt > > 2.Do the comunication through drivers/rpmsg > > https://www.kernel.org/doc/Documentation/rpmsg.txt > > Many vendor(TI, Qualcomm, ST, NXP, Xilinx...) migrate to remoteproc/rpmsg, why Intel provide an other IPC mechanism? > > It definitely makes more sense to use rpmsg for Generic IPC driver here. > > Qualcomm DSP audio drivers (non SOF) already use rpmsg. This will > definitely help everyone in future while immigrating to SOF. > Actually, Xiaomi also build DSP audio driver on top of rpmsg, but fully integrate with the ASoC topology framework, and the firmware is base on FreeRTOS and OpenMAX. SOF initiative is very good and exciting, our team members(include me) spend a couple weeks to study the current code base on both firmware and kernel side, we even port SOF to our DSP/MCU and make it run, but I have to point out that: SOF IPC is too simple and rigid, tightly couple with Intel platform and audio domain, which make: a.It's difficult to integrate with other vendor SoC, especially if other vendor already adopt remote/rpmsg(this is already a trend!). b.It's difficult to add other IPC services for example: i.Audio DSP talk to power MCU to adjust clock and voltage ii.Export ultrasonic distance measurement to IIO subsystem > > Actually, remoteproc/rpmsg is much better than SOF IPC because: > > 1.Completely isolate the firmware load and message transfer: > > The same rpmsg driver could run on any remote processor > > 2.Separate the application protocol from transfer layer: > > One remote processor could host many rpmsg services > > 3.Completely follow kernel driver model(rpsmg_bus, rpmsg_device and rpmsg_driver). > > 4.Support by many RTOS(Bare Metal, FreeRTOS, Zephyr, NuttX, Nucleus, uC/OS...) for remote side: > > https://github.com/OpenAMP/open-amp > > https://github.com/NXPmicro/rpmsg-lite > > 5.Maintained by the standard committee: > > https://www.multicore-association.org/workgroup/oamp.php > > https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio > > Since the keypoint of SOF is the platform agnostic and modular, please use the standard technique here. > > > > Thanks > > Xiang > > _______________________________________________ > > Alsa-devel mailing list > > Alsa-devel(a)alsa-project.org > > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > > > --srini

6 13

Re: [Sound-open-firmware] [alsa-devel] [PATCH v4 01/14] ASoC: SOF: Add Sound Open Firmware driver core
by Pierre-Louis Bossart 22 Feb '19

22 Feb '19

On 2/21/19 12:47 PM, Mark Brown wrote: > On Wed, Feb 20, 2019 at 03:32:54PM -0600, Pierre-Louis Bossart wrote: > >> The only reason for extending the struct snd_soc_pcm_runtime was to enable >> the use of a 'context' in PCM operations, see e.g in patch 5/14 the repeated >> pattern to get an 'SOF PCM' context: >> struct snd_sof_pcm *spcm = rtd->private; > The reason you're having trouble with this is that the DSP isn't really > properly visible in the system, it's pushed in on the side with DPCM > coexisting with multiple other drivers so as far as I can see it's hard > for it to fit in anywhere in Intel systems. > >> So ironically in ASoC we don't have a means to use a private_data field for >> the substreams since it's used for a 'standard' mechanism. > This is why there's things like snd_soc_dai_get_dma_data() and > snd_soc_component_get_drvdata() - if you're a fully visible component in > the system there's ways to get to your ASoC specific driver data. For > something like SoF that'd mean cooperating with the drivers for the > devices with the SoF using DSPs in some way. > >> The extension suggested in this patch 1/14 was really trying to come back to >> a practical means to store a context in a substream, and make the PCM >> operations manageable. I totally agree that extending the PCM runtime might >> not recommended or safe, but at this point I don't have any slack in the >> existing data structures to add a context in a substream. >> Does this help clarify the problem statement? > It is fairly clear what driver data is useful for. The issue is that > instead of getting to it through the relevant hardware component you're > adding something directly in the core data structure, whatever way we > look at it that's going to be awkward. Consider for example what > happens if someone integrates a system with a SoF DSP in the SoC and > another SoF DSP in the CODEC - there will be two separate copies of SoF > on a single DAI so a SoF specific value directly in the runtime isn't > going to work. > > If there were a component for the DSP (or the DSP was fully part of some > other existing component) then it should be possible to arrange to get > to the DSP data using that but with it just floating there unattached to > anything it's harder. After spending a bit more time on this, I agree it's possible to retrieve the required information without any change to the rtd structure. There are existing precedents using substream->runtime->private_data, e.g. to store an HDAudio stream tag, and SOF already has a list of contexts that can be searched for with a simple list walk. Modeling the DSP differently is something I'll add to my growing-by-the-day TODO list.

1 0

Re: [Sound-open-firmware] [alsa-devel] [v4, 00/14] ASoC: Sound Open Firmware (SOF) core
by Pierre-Louis Bossart 22 Feb '19

22 Feb '19

>> Just for information... ST Microelectronics plans to port SOF to at >> least one of its platforms (based on ARM cores). Today, for the >> co-processor management we use the rpmsg and remoteproc frameworks on >> the Linux kernel side and OpenAMP on the remote processor side. We are >> therefore interested in xiang's work. >> An advantage we see in this generic solution is that compatibility >> between the Linux kernel frameworks and the OpenAMP library is ensured >> through discussions in the Linux and OpenAMP communities, involving >> maintainers and several vendors. Thanks Arnaud for sharing this information. You made my day. We've had to deal with a number of hurdles related to platform and tools availability, so it's good news indeed if there are more platforms endorsing SOF. > This is a very good point, especially with people actually jumping on it > if we can avoid having multiple ABIs to worry about that would make life > a lot easier. We should at least figure out if it will be disruptive to > adapt it later on, even if Intel ends up continuing to use a custom > system integration. Yes indeed. At a high level we only have very generic send/receive IPC messages, and it really shouldn't matter how the transport happens. However the actual contents/semantics of the messages do matter, and I'll have to run a check to make sure it scales.

1 0

Re: [Sound-open-firmware] [PATCH v4 07/14] ASoC: SOF: Add DSP firmware logger support
by Pierre-Louis Bossart 21 Feb '19

21 Feb '19

On 2/20/19 11:44 AM, Mark Brown wrote: > On Wed, Feb 13, 2019 at 04:07:27PM -0600, Pierre-Louis Bossart wrote: > >> + /* make sure count is <= avail */ >> + count = avail > count ? count : avail; > count = min(avail, count)? as discussed in the last review, we didn't use min() since it adds a number of obscure warnings with sparse. I haven't found any time to look into this so for now left the code as is. Sparse is a useful tool for the address checks (topology/DMAs with _le32, __iomem, etc), the fewer warnings we get the better.

2 2

Re: [Sound-open-firmware] [PATCH v4 01/14] ASoC: SOF: Add Sound Open Firmware driver core
by Pierre-Louis Bossart 20 Feb '19

20 Feb '19

On 2/20/19 10:26 AM, Mark Brown wrote: > On Wed, Feb 20, 2019 at 08:35:16AM -0600, Pierre-Louis Bossart wrote: > >> I see your point and agree the current direction isn't scalable, but I am >> not sure about the definition of 'first class device'. >> Did you mean 'component' at the same level as the 'platforms' and 'codecs', >> with all the DSP stuff nicely packaged and maintained in a self-contained >> way? >> Or a subcomponent that might be part of those platforms and codecs? > As far as I can see for the Intel systems it's looking like a first > class component - there will be some systems where the DSP is embedded > in something (like the big CODECs) but even there it's easier as it's > contained within the device rather than affecting multiple devices which > is the big issue here. Sorry Mark, I am struggling with the 'first class' idea. Allow me to go back to the practical issue we faced here, and maybe/hopefully this will help us converge on a consensus. The only reason for extending the struct snd_soc_pcm_runtime was to enable the use of a 'context' in PCM operations, see e.g in patch 5/14 the repeated pattern to get an 'SOF PCM' context: struct snd_sof_pcm *spcm = rtd->private; Managing a context for PCM ops is typically done in other drivers by using the substream->private_data aka snd_pcm_substream_chip(substream). In ASoC/DPCM, unfortunately this substream->private_data field was reclaimed to store a pointer to a 'struct snd_soc_pcm_runtime', see e.g. in soc-pcm.c: pcm->private_data = rtd; if (playback) pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream->private_data = rtd; if (capture) pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream->private_data = rtd; So ironically in ASoC we don't have a means to use a private_data field for the substreams since it's used for a 'standard' mechanism. The extension suggested in this patch 1/14 was really trying to come back to a practical means to store a context in a substream, and make the PCM operations manageable. I totally agree that extending the PCM runtime might not recommended or safe, but at this point I don't have any slack in the existing data structures to add a context in a substream. Does this help clarify the problem statement?

1 0