- Sound-open-firmware - mailman.alsa-project.org

Re: [Sound-open-firmware] [alsa-devel] [PATCH v3 02/14] ASoC: SOF: Add Sound Open Firmware KControl support
by Pierre-Louis Bossart 11 Dec '18

11 Dec '18

>> + max_size = (be->max < max_size) ? be->max : max_size; > min() / max() ? Good catch, this can be simplified. Not sure I like max_size = min (be->max, max_size), it's confusing. Maybe if (be->max < max_size) max_size = be->max;

1 0

[Sound-open-firmware] MIC record support on Apollo lake
by Muhammed, Wasim 16 Nov '18

16 Nov '18

Hi , I am trying to add MIC as an record device in the SOF firmware on the Apollo lake MRB platform. Is this supported by the SOF architecture already? Your response is highly appreciated. Thanks BR Wasim

2 2

[Sound-open-firmware] FW: GLK v0.5 release for Google - SoF Tools Build Error
by M, Naveen 09 Oct '18

09 Oct '18

JFYI, (re-sent due to access issues) Can you please guide me with below issue. Thanks, Naveen From: M, Naveen Sent: Monday, October 1, 2018 10:44 AM To: 'sound-open-firmware(a)alsa-project.org' <sound-open-firmware(a)alsa-project.org> Subject: GLK v0.5 release for Google - SoF Tools Build Error Hello All, Tried building SoFT as per the release document(SoF commits as below) but observe following issue. SOF FW source https://github.com/thesofproject/sof/tree/glk-003-drop-stable Commit: 0ead9e762b36b87cd59afe44e90f912978a79fad (marked as: https://github.com/thesofproject/sof/releases/tag/0ead9e7 ) SOF topology https://github.com/thesofproject/soft/tree/master Commit: 918e4013191f67600dd11eb2d40bc7535b7aa3c9 SOF Drivers source https://github.com/thesofproject/linux/tree/topic/cros-sof-v4.14-rebase 3d04ca232eebd739cbdabeeb0ec9ea705fdbafec Build Error Log: Making all in logger make[2]: Entering directory '/home/nm/google/sof/soft/logger' gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -MT logger.o -MD -MP -MF .deps/logger.Tpo -c -o logger.o logger.c logger.c:7:10: fatal error: /usr/local/include/sof/uapi/logging.h: No such file or directory #include "/usr/local/include/sof/uapi/logging.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. Makefile:353: recipe for target 'logger.o' failed make[2]: *** [logger.o] Error 1 make[2]: Leaving directory '/home/nm/google/sof/soft/logger' Makefile:365: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/home/nm/google/sof/soft' Makefile:306: recipe for target 'all' failed make: *** [all] Error 2 NOTE: make from path soft/topology, generates the topology binary & .conf fine Did I miss anything ? Please guide me. Thanks, Naveen

3 3

Re: [Sound-open-firmware] Any SOF pcm hw parameters change that can disable PAUSE on GLK?
by Lin, Mengdong 09 Oct '18

09 Oct '18

Hi Marcin/Wojtek, Could you run "dmesg" and share the output? As well as the output of "aplay -l" and "lsmod"? Maybe there is something wrong when SOF opens the PCM. It seems driver will always enable PAUSE if sof_pcm_open() succeeds by setting SNDRV_PCM_INFO_PAUSE. Please see https://github.com/thesofproject/linux/blob/topic/sof-dev/sound/soc/sof/pcm… static int sof_pcm_open(struct snd_pcm_substream *substream) { ... /* set runtime config */ runtime->hw.info = SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID | SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME | SNDRV_PCM_INFO_NO_PERIOD_WAKEUP; ... } Thanks Mengdong > -----Original Message----- > From: Maka, Marcin > Sent: Tuesday, October 9, 2018 6:45 PM > To: Jie, Yang <yang.jie(a)intel.com>; Lin, Mengdong > <mengdong.lin(a)intel.com>; OTC Linux Audio <otc.linux.audio(a)intel.com>; > Wittbrodt, WojciechX <wojciechx.wittbrodt(a)intel.com> > Cc: sound-open-firmware(a)alsa-project.org > Subject: RE: Any SOF pcm hw parameters change that can disable PAUSE on > GLK? > > I am using SOF stack built by Wojtek and installed on Yorp. > > > -----Original Message----- > > From: Jie, Yang > > Sent: Tuesday, October 9, 2018 11:45 AM > > To: Lin, Mengdong <mengdong.lin(a)intel.com>; OTC Linux Audio > > <otc.linux.audio(a)intel.com>; Maka, Marcin <marcin.maka(a)intel.com> > > Cc: sound-open-firmware(a)alsa-project.org > > Subject: RE: Any SOF pcm hw parameters change that can disable PAUSE > on GLK? > > > > > > I bet you are not using SOF driver, Marcin? > > > > We need to configure pcm info with SNDRV_PCM_INFO_PAUSE if you > want > > your PCM supporting that, please refer to sof/pcm.c:404 for that. > > > > Thanks, > > ~Keyon > > > > > > >-----Original Message----- > > >From: Lin, Mengdong > > >Sent: Tuesday, October 9, 2018 5:27 PM > > >To: OTC Linux Audio <otc.linux.audio(a)intel.com>; Maka, Marcin > > ><marcin.maka(a)intel.com> > > >Cc: sound-open-firmware(a)alsa-project.org > > >Subject: Any SOF pcm hw parameters change that can disable PAUSE on > GLK? > > > > > >Could someone share some insight here? > > > > > >This is an issue observed by Marcin on GNL platform. > > >When he runs 'aplay Ring09.wav -vv -I' and press SPACE to > > >pause/resume, aplay will complain: PAUSE command ignored (no hw > > >support) > > > > > >aplay.c will call snd_pcm_hw_params_can_pause() and decide whethter > > >HW supports pause. It seems hw parameter indicates that PAUSE cannot > > >be supported. > > > > > >Here is snd_pcm_hw_params_can_pause defined in alsa-lib pcm.c > > >/** > > >3487 * \brief Check if hardware supports pause > > >3488 * \param params Configuration space > > >3489 * \retval 0 Hardware doesn't support pause > > >3490 * \retval 1 Hardware supports pause > > >3491 * > > >3492 * This function should only be called when the configuration > > >space > > >3493 * contains a single configuration. Call #snd_pcm_hw_params to > > >choose > > >3494 * a single configuration from the configuration space. > > >3495 */ > > >3496 int snd_pcm_hw_params_can_pause(const > snd_pcm_hw_params_t > > >*params) > > >3497 { > > >3498 assert(params); > > >3499 if (CHECK_SANITY(params->info == ~0U)) { > > >3500 SNDMSG("invalid PCM info field"); > > >3501 return 0; /* FIXME: should be a negative error? */ > > >3502 } > > >3503 return !!(params->info & SNDRV_PCM_INFO_PAUSE); > > >3504 } > > > > > >Thanks > > >Mengdong > > >

1 0

[Sound-open-firmware] Any SOF pcm hw parameters change that can disable PAUSE on GLK?
by Lin, Mengdong 09 Oct '18

09 Oct '18

Could someone share some insight here? This is an issue observed by Marcin on GNL platform. When he runs 'aplay Ring09.wav -vv -I' and press SPACE to pause/resume, aplay will complain: PAUSE command ignored (no hw support) aplay.c will call snd_pcm_hw_params_can_pause() and decide whethter HW supports pause. It seems hw parameter indicates that PAUSE cannot be supported. Here is snd_pcm_hw_params_can_pause defined in alsa-lib pcm.c /** 3487 * \brief Check if hardware supports pause 3488 * \param params Configuration space 3489 * \retval 0 Hardware doesn't support pause 3490 * \retval 1 Hardware supports pause 3491 * 3492 * This function should only be called when the configuration space 3493 * contains a single configuration. Call #snd_pcm_hw_params to choose 3494 * a single configuration from the configuration space. 3495 */ 3496 int snd_pcm_hw_params_can_pause(const snd_pcm_hw_params_t *params) 3497 { 3498 assert(params); 3499 if (CHECK_SANITY(params->info == ~0U)) { 3500 SNDMSG("invalid PCM info field"); 3501 return 0; /* FIXME: should be a negative error? */ 3502 } 3503 return !!(params->info & SNDRV_PCM_INFO_PAUSE); 3504 } Thanks Mengdong

2 1

[Sound-open-firmware] GLK v0.5 release for Google - SoF Tools Build Error
by M, Naveen 01 Oct '18

01 Oct '18

Hello All, Tried building SoFT as per the release document(SoF commits as below) but observe following issue. SOF FW source https://github.com/thesofproject/sof/tree/glk-003-drop-stable Commit: 0ead9e762b36b87cd59afe44e90f912978a79fad (marked as: https://github.com/thesofproject/sof/releases/tag/0ead9e7 ) SOF topology https://github.com/thesofproject/soft/tree/master Commit: 918e4013191f67600dd11eb2d40bc7535b7aa3c9 SOF Drivers source https://github.com/thesofproject/linux/tree/topic/cros-sof-v4.14-rebase 3d04ca232eebd739cbdabeeb0ec9ea705fdbafec Build Error Log: Making all in logger make[2]: Entering directory '/home/nm/google/sof/soft/logger' gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -MT logger.o -MD -MP -MF .deps/logger.Tpo -c -o logger.o logger.c logger.c:7:10: fatal error: /usr/local/include/sof/uapi/logging.h: No such file or directory #include "/usr/local/include/sof/uapi/logging.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. Makefile:353: recipe for target 'logger.o' failed make[2]: *** [logger.o] Error 1 make[2]: Leaving directory '/home/nm/google/sof/soft/logger' Makefile:365: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/home/nm/google/sof/soft' Makefile:306: recipe for target 'all' failed make: *** [all] Error 2 NOTE: make from path soft/topology, generates the topology binary & .conf fine Did I miss anything ? Please guide me. Thanks, Naveen

1 0

[Sound-open-firmware] SOF repos
by Daniel Baluta 28 Sep '18

28 Sep '18

Hi Liam et all, What are the latest SOF repos? I noticed that sof repos can be found in two places: 1) https://github.com/thesofproject/ and 2) http://git.alsa-project.org/ Also, what branches are stable enough for testing? :) thanks, Daniel.

2 1

[Sound-open-firmware] Disable SOF power management on BYT by default?
by Lin, Mengdong 25 Sep '18

25 Sep '18

Hi, It seems the power management is enabled by default for platforms, since I found SET_RUNTIME_PM_OPS is set in both sof-acpi-dev.c and sof-pci-dev.c. However, I feel only APL+ platforms can support this feature. So maybe we need to disable this on BYT by default? Thanks Mengdong

2 1

[Sound-open-firmware] Introduction and questions
by chris hermansen 20 Sep '18

20 Sep '18

I write a column on open source and music on https://opensource.com/ Recently I was at Open Summit and learned of this project. I subsequently contacted some folks at Intel to learn more about how this project might affect users of open source media players. One of my contacts advised posting questions to this list. To avoid spamming the list any more than I already have, I'd like to confirm that a few such questions won't be a supreme annoyance to the list members. Thanks in advance for any advice. -- Chris Hermansen · clhermansen "at" gmail "dot" com C'est ma façon de parler.

3 5

[Sound-open-firmware] [ANNOUNCE] SOF at OSFC 2018
by Liam Girdwood 06 Sep '18

06 Sep '18

Hello all, Next week on September 12th, I will be speaking at Sound Open Firmware at the Open Source Firmware Conference in Erlangen. I will share lessons learned from open sourcing Sound Open Firmware. If you're attending or will be around the area, drop by to hear more. Hope to see you there. More info here: https://www.sofproject.org/event/open-source-firmware-conference-2018/ Cheers, Liam

1 0