- Sound-open-firmware - mailman.alsa-project.org

[Sound-open-firmware] Codec Adapters Upstream
by Curtis Malainey 19 Dec '20

19 Dec '20

Hello All I know historically there was push back against codec/processing adapters upstream. Now that we have UUID support and the codec adapter, are we still pushing back on this? Curtis

2 4

[Sound-open-firmware] Output channel left/right swap on various CHT devices with various codecs
by Hans de Goede 18 Dec '20

18 Dec '20

Hi Pierre-Louis, et al., As discussed in other email-threads, because of the plan to drop the old SST Linux driver for BYT/CHT devices, replacing it with the SOF driver, I have been testing the Linux SOF driver on various BYT and CHT devices. As also already discussed things mostly work well, but there is one bug when using the SOF driver which is not present when using the SST driver. Sometimes the left and right playback channels are swapped. This happens with both stereo speakers and headphones (as is to be expected). I just hit this on a CHT SoC + NAU8824 codec device, meaning that I can now confirm the playback channel-swap issue on 2 different devices. So I've gone ahead and filed an issue for this: https://github.com/thesofproject/sof/issues/3699 As mentioned in the issue I would like to file an official Fedora Change proposal for making SOF the default sound driver for BYT/CHT devices in Fedora 34, to help with SOF getting tested on those devices so that we can drop the older SST driver ASAP. This playback channel-swap issue is IHMO a blocker for this plan, as I mentioned in the issue the deadline for filing a change proposal for this is Jan 19th 2021. We can always flip the default back to SST later during the Fedora 34 development-cycle if this issue stay unresolved, but I would like to at least have some indication / expectation of a fix for this being available no later then say February 15th, before moving ahead with the Fedora change plan. Regards, Hans

2 1

[Sound-open-firmware] [PATCH sof] topology: Add sof-cht-nau8824 topology file
by Hans de Goede 17 Dec '20

17 Dec '20

Add a topology file for Cherry Trail boards with a NAU8824 codec. These setups work with the standard settings from sof-byt-codec.m4. This has been tested on the following devices: Medion E2215T: stereo speakers, analog mic Medion E2228T: stereo speakers, stereo digital mics Cube iWork8 Air: mono speaker, analog mic Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- tools/topology/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/topology/CMakeLists.txt b/tools/topology/CMakeLists.txt index 170663aed..a3bfe18ee 100644 --- a/tools/topology/CMakeLists.txt +++ b/tools/topology/CMakeLists.txt @@ -63,6 +63,7 @@ set(TPLGS "sof-byt-codec\;sof-cht-da7213\;-DCODEC=DA7213\;-DPLATFORM=cht-codec\;-DSSP_NUM=2" "sof-byt-codec\;sof-cht-cx2072x\;-DCODEC=CX2072X\;-DPLATFORM=cht-codec\;-DSSP_NUM=2" "sof-byt-codec\;sof-cht-es8316\;-DCODEC=ES8316\;-DPLATFORM=cht-codec\;-DSSP_NUM=2" + "sof-byt-codec\;sof-cht-nau8824\;-DCODEC=NAU8824\;-DPLATFORM=cht-codec\;-DSSP_NUM=2" "sof-cht-max98090\;sof-cht-max98090\;-DCODEC=MAX98090\;-DPLATFORM=cht-codec\;-DSSP_NUM=2" "sof-cnl-rt274\;sof-cnl-rt274" "sof-apl-tdf8532\;sof-apl-tdf8532" -- 2.28.0

3 3

[Sound-open-firmware] [PATCH] ASoC: SOF: Fix spelling mistake in Kconfig "ond" -> "and"
by Colin King 16 Dec '20

16 Dec '20

From: Colin Ian King <colin.king(a)canonical.com> There is a spelling mistake in the Kconfig help text. Fix it. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/soc/sof/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index 031dad5fc4c7..3e8b6c035ce3 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -122,7 +122,7 @@ config SND_SOC_SOF_DEBUG_XRUN_STOP bool "SOF stop on XRUN" help This option forces PCMs to stop on any XRUN event. This is useful to - preserve any trace data ond pipeline status prior to the XRUN. + preserve any trace data and pipeline status prior to the XRUN. Say Y if you are debugging SOF FW pipeline XRUNs. If unsure select "N". -- 2.29.2

3 2

[Sound-open-firmware] Design decisions for PM flow
by Daniel Baluta 15 Dec '20

15 Dec '20

Hi Ranjani, I have few questions about PM flow in SOF. 1) Firmware is always loaded at SOF device probe. Why is that? Is this just an early check that DSP is OK? Because after SND_SOF_SUSPEND_DELAY_MS the SOF device is suspended and DSP is turned off. 2) What is the correct behavior when immediately after boot there is a PM suspend/PM resume cycle. Here is what happens on IMX. PM suspend -> will do nothing because DSP is already suspended PM resume -> will reload the firmware. But now the firmware is loaded and DSP is up. And the system stays like this. How does this looks like on Intel platforms. thanks, Daniel.

3 5

[Sound-open-firmware] Sof-audio error
by Marc Green 15 Dec '20

15 Dec '20

Hi all, I have recently got a new Dell G5 laptop for research and have installed Ubuntu 20.04. When the Nvidia graphics card is selected as a device, I get the error: sof-audio-pci 0000:00:1f.3: error: no reply expected, received 0x0 Popping up on screen every time I wake the computer from sleep. Do you have any idea how I might fix this, as it's really annoying! I've contacted Nvidia too. Cheers, Marc

2 1

[Sound-open-firmware] [PATCH AUTOSEL 5.9 04/55] ASoC: SOF: loader: handle all SOF_IPC_EXT types
by Sasha Levin 10 Nov '20

10 Nov '20

From: Bard Liao <yung-chuan.liao(a)linux.intel.com> [ Upstream commit 6e5329c6e6032cd997400b43b8299f607a61883e ] Do not emit a warning for extended firmware header fields that are not used by kernel. This creates unnecessary noise to kernel logs like: sof-audio-pci 0000:00:1f.3: warning: unknown ext header type 3 size 0x1c sof-audio-pci 0000:00:1f.3: warning: unknown ext header type 4 size 0x10 Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski(a)linux.intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Link: https://lore.kernel.org/r/20201021182419.1160391-1-kai.vehmanen@linux.intel… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/sof/loader.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/sof/loader.c b/sound/soc/sof/loader.c index b94fa5f5d4808..c90c3f3a3b3ee 100644 --- a/sound/soc/sof/loader.c +++ b/sound/soc/sof/loader.c @@ -118,6 +118,11 @@ int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset) case SOF_IPC_EXT_CC_INFO: ret = get_cc_info(sdev, ext_hdr); break; + case SOF_IPC_EXT_UNUSED: + case SOF_IPC_EXT_PROBE_INFO: + case SOF_IPC_EXT_USER_ABI_INFO: + /* They are supported but we don't do anything here */ + break; default: dev_warn(sdev->dev, "warning: unknown ext header type %d size 0x%x\n", ext_hdr->type, ext_hdr->hdr.size); -- 2.27.0

1 0

Re: [Sound-open-firmware] linux-next: Tree for Nov 6 (sound/soc/sof/sof-pci-dev.o)
by Randy Dunlap 06 Nov '20

06 Nov '20

On 11/5/20 10:18 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20201105: > on x86_64: ld: sound/soc/sof/sof-pci-dev.o: in function `sof_pci_probe': sof-pci-dev.c:(.text+0x5c): undefined reference to `snd_intel_dsp_driver_probe' Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap <rdunlap(a)infradead.org>

2 2

[Sound-open-firmware] [PATCH AUTOSEL 5.9 039/147] ASoC: SOF: fix a runtime pm issue in SOF when HDMI codec doesn't work
by Sasha Levin 05 Nov '20

05 Nov '20

From: Rander Wang <rander.wang(a)intel.com> [ Upstream commit 6c63c954e1c52f1262f986f36d95f557c6f8fa94 ] When hda_codec_probe() doesn't initialize audio component, we disable the codec and keep going. However,the resources are not released. The child_count of SOF device is increased in snd_hdac_ext_bus_device_init but is not decrease in error case, so SOF can't get suspended. snd_hdac_ext_bus_device_exit will be invoked in HDA framework if it gets a error. Now copy this behavior to release resources and decrease SOF device child_count to release SOF device. Signed-off-by: Rander Wang <rander.wang(a)intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski(a)linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Link: https://lore.kernel.org/r/20200825235040.1586478-3-ranjani.sridharan@linux.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/sof/intel/hda-codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c index 2c5c451fa19d7..c475955c6eeba 100644 --- a/sound/soc/sof/intel/hda-codec.c +++ b/sound/soc/sof/intel/hda-codec.c @@ -151,7 +151,7 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address, if (!hdev->bus->audio_component) { dev_dbg(sdev->dev, "iDisp hw present but no driver\n"); - return -ENOENT; + goto error; } hda_priv->need_display_power = true; } @@ -174,7 +174,7 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address, * other return codes without modification */ if (ret == 0) - ret = -ENOENT; + goto error; } return ret; -- 2.25.1

3 3

[Sound-open-firmware] [PATCH AUTOSEL 5.8 035/132] ASoC: SOF: fix a runtime pm issue in SOF when HDMI codec doesn't work
by Sasha Levin 27 Oct '20

27 Oct '20

From: Rander Wang <rander.wang(a)intel.com> [ Upstream commit 6c63c954e1c52f1262f986f36d95f557c6f8fa94 ] When hda_codec_probe() doesn't initialize audio component, we disable the codec and keep going. However,the resources are not released. The child_count of SOF device is increased in snd_hdac_ext_bus_device_init but is not decrease in error case, so SOF can't get suspended. snd_hdac_ext_bus_device_exit will be invoked in HDA framework if it gets a error. Now copy this behavior to release resources and decrease SOF device child_count to release SOF device. Signed-off-by: Rander Wang <rander.wang(a)intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski(a)linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> Link: https://lore.kernel.org/r/20200825235040.1586478-3-ranjani.sridharan@linux.… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/sof/intel/hda-codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c index 2c5c451fa19d7..c475955c6eeba 100644 --- a/sound/soc/sof/intel/hda-codec.c +++ b/sound/soc/sof/intel/hda-codec.c @@ -151,7 +151,7 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address, if (!hdev->bus->audio_component) { dev_dbg(sdev->dev, "iDisp hw present but no driver\n"); - return -ENOENT; + goto error; } hda_priv->need_display_power = true; } @@ -174,7 +174,7 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address, * other return codes without modification */ if (ret == 0) - ret = -ENOENT; + goto error; } return ret; -- 2.25.1

1 0