May 2023 - Sound-open-firmware - mailman.alsa-project.org

[PATCH] ASoC: SOF: amd: Fix NULL pointer crash in acp_sof_ipc_msg_data function
by V sujith kumar Reddy 09 May '23

09 May '23

Check substream and runtime variables before assigning. Signed-off-by: V sujith kumar Reddy <Vsujithkumar.Reddy(a)amd.com> --- sound/soc/sof/amd/acp-ipc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/soc/sof/amd/acp-ipc.c b/sound/soc/sof/amd/acp-ipc.c index 4e0c48a36159..749e856dc601 100644 --- a/sound/soc/sof/amd/acp-ipc.c +++ b/sound/soc/sof/amd/acp-ipc.c @@ -209,7 +209,12 @@ int acp_sof_ipc_msg_data(struct snd_sof_dev *sdev, struct snd_sof_pcm_stream *sp acp_mailbox_read(sdev, offset, p, sz); } else { struct snd_pcm_substream *substream = sps->substream; - struct acp_dsp_stream *stream = substream->runtime->private_data; + struct acp_dsp_stream *stream; + + if (!substream || !substream->runtime) + return -ESTRPIPE; + + stream = substream->runtime->private_data; if (!stream) return -ESTRPIPE; -- 2.25.1

2 1

Re: [alsa-devel@alsa-project.org: [PATCH 3/5] ASoC: mediatek: mt8195-afe-pcm: Simplify runtime PM during probe]
by Geraldo Nascimento 08 May '23

08 May '23

On Mon, May 08, 2023 at 08:33:59AM +0900, Mark Brown wrote: > On Fri, May 05, 2023 at 11:17:19PM -0300, Geraldo Nascimento wrote: > > On Sat, May 06, 2023 at 09:13:06AM +0900, Mark Brown wrote: > > > > Not just the headers in the message, the author information for the mail > > > also got rewritten. Try applying the patches with git am... > > > Mark, I think Jaroslav can change the behaviour in the the added Headers in the > > body of the message (the added Headers in the body have e.g. the correct From: > > email information). > > > If the message body *starts* with the "From:", "Subject:" and "Date:" fields > > I think git-am will pickup the correct information from the body instead of from > > the mangled headers. > > > Hopefully... > > No, it absolutely doesn't work properly - I only noticed this was > happening because b4/lore keep picking the copy from alsa-devel which is > mangled to the point of not being usable. Hi Mark, sorry to hear that. The fact mailman is disrupting your workflow as ASoC maintainer is alarming, and I hope you and Jaroslav can work out a solution. But besides my suggestion that the added headers in the body of the message *start* with at least the correct "From:" field, I can't be of much help. Thanks for the hard work, Geraldo Nascimento

1 0

Re: [alsa-devel@alsa-project.org: [PATCH 3/5] ASoC: mediatek: mt8195-afe-pcm: Simplify runtime PM during probe]
by Geraldo Nascimento 06 May '23

06 May '23

On Sat, May 06, 2023 at 09:13:06AM +0900, Mark Brown wrote: > On Fri, May 05, 2023 at 05:38:28PM -0300, Geraldo Nascimento wrote: > > On Thu, May 04, 2023 at 10:09:45AM +0900, Mark Brown wrote: > > > > Here's another mail (one of several in this series) that got completely > > > mangled by the alsa-project.org mailman to the point of unusability. I > > > didn't see any response to my last mail about this, is there any news on > > > fixing mailman to not do this? It's extremely disruptive to working > > > with lore. > > > Are you complaining about the added headers in the message? Because the > > patch itself didn't look mangled from my side. From my understanding, > > Jaroslav had to start mangling mail addresses due to strict DMARC rules > > which make some servers reject the message from alsa-devel. > > Not just the headers in the message, the author information for the mail > also got rewritten. Try applying the patches with git am... Mark, I think Jaroslav can change the behaviour in the the added Headers in the body of the message (the added Headers in the body have e.g. the correct From: email information). If the message body *starts* with the "From:", "Subject:" and "Date:" fields I think git-am will pickup the correct information from the body instead of from the mangled headers. Hopefully... Good luck, Geraldo Nascimento

1 0

Re: [alsa-devel@alsa-project.org: [PATCH 3/5] ASoC: mediatek: mt8195-afe-pcm: Simplify runtime PM during probe]
by Geraldo Nascimento 05 May '23

05 May '23

On Thu, May 04, 2023 at 10:09:45AM +0900, Mark Brown wrote: > Hi, > > Here's another mail (one of several in this series) that got completely > mangled by the alsa-project.org mailman to the point of unusability. I > didn't see any response to my last mail about this, is there any news on > fixing mailman to not do this? It's extremely disruptive to working > with lore. Hi Mark, Are you complaining about the added headers in the message? Because the patch itself didn't look mangled from my side. From my understanding, Jaroslav had to start mangling mail addresses due to strict DMARC rules which make some servers reject the message from alsa-devel. Thanks, Geraldo Nascimento > > Thanks, > Mark

1 0

Bad magic error when loading SOF firmware
by David Sayada 04 May '23

04 May '23

Hello SOF team, We are trying to evaluate the SOF project on our 8MPLUSSLPD4-EVK based product, and we are getting some issues when trying to run one of the "yocto compiled" SOF Firmware. Below is the procedure we are trying to perform: *echo /lib/firmware/imx/sof/sof-imx8m.ri > /sys/class/remoteproc/remoteproc0/firmware* *echo start > /sys/class/remoteproc/remoteproc0/state* We are getting, at the end, a "Image is corrupted (bad magic)" -22 return code. We have also created a VM (based on SOF 2.4.1) where we can compile (and sign, with default keys) the different toolchains and firmwares. Will that help in having a firmware run correctly? Maybe, we are doing incorrect things, if this is the case, please advise. Best regards, David Sayada.

2 5

[PATCH 0/5] ASoC: MediaTek MT8195/86 Cleanups
by AngeloGioacchino Del Regno 03 May '23

03 May '23

This series performs some cleanups for mainly MT8195 and switches both MT8195 and MT8186's SOF driver to the snd_sof_ipc_process_reply() helper. AngeloGioacchino Del Regno (5): ASoC: SOF: mediatek: mt8195: Use snd_sof_ipc_process_reply() helper ASoC: SOF: mediatek: mt8186: Use snd_sof_ipc_process_reply() helper ASoC: mediatek: mt8195-afe-pcm: Simplify runtime PM during probe ASoC: mediatek: mt8195-afe-pcm: Simplify with dev_err_probe() ASoC: mediatek: mt8195-afe-pcm: Clean up unnecessary functions sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 99 ++++++++-------------- sound/soc/sof/mediatek/mt8186/mt8186.c | 36 +------- sound/soc/sof/mediatek/mt8195/mt8195.c | 36 +------- 3 files changed, 36 insertions(+), 135 deletions(-) -- 2.40.1

3 9